Fix multilevel artifact downloads#43
Open
imrehg wants to merge 2 commits into
Open
Conversation
imrehg
force-pushed
the
multilevel-download
branch
from
9b3df6f to
30f13f2
Compare
srstevenson
suggested changes
Jan 22, 2020
imrehg
force-pushed
the
multilevel-download
branch
from
7d6eb6a to
e5d56de
Compare
srstevenson
approved these changes
Jan 30, 2020
Models can be registered with subfolders, for example such as: ``` test ├── subdir │ └── sub.file └── top.file ``` In the current form, when one requests this model, the library downloads all files, but the files from the subdirectories are downloaded multiple times: in the root, and also in their subfolder (and along all the subfolders, if there are even more levels): ``` test ├── subdir │ └── sub.file ├── sub.file └── top.file ``` This is because `mlflow` expects a list of files & directories in a path, but doesn't expect all the items recursively within a subdir, since there are extra steps when they traverse those subdirectories. With this change, when `mlflow` requests a list of artifacts at a given path, only return the files and directories directly there, and filter out all other recursive items (which `mlflow` will request later on). Signed-off-by: Gergely Imreh <gergely.imreh@faculty.ai>
Signed-off-by: Gergely Imreh <gergely.imreh@faculty.ai>
imrehg
force-pushed
the
multilevel-download
branch
from
e5d56de to
7e6edb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Models can be registered with subfolders, for example such as:
In the current form, when one requests this model, the library downloads all files, but the files from the subdirectories are downloaded multiple times: in the root, and also in their subfolder (and along all
the subfolders, if there are even more levels):
This is because
mlflowexpects a list of files & directories in a path, but doesn't expect all the items recursively within a subdir, since there are extra steps when they traverse those subdirectories.With this change, when
mlflowrequests a list of artifacts at a given path, only return the files and directories directly there, and filter out all other recursive items (whichmlflowwill request later on).Signed-off-by: Gergely Imreh gergely.imreh@faculty.ai