Fix support for mono and 5.1 Vorbis files#154
Open
samhocevar wants to merge 1 commit intofaiface:masterfrom
Open
Fix support for mono and 5.1 Vorbis files#154samhocevar wants to merge 1 commit intofaiface:masterfrom
samhocevar wants to merge 1 commit intofaiface:masterfrom
Conversation
The code no longer assumes Vorbis files are stereo (they may have up to 255 channels), which caused e.g. mono files to play at twice their speed. The current strategy for files with more than 2 channels is to only play the first and last channels, and drop the rest.
This was referenced Mar 22, 2023
Open
Contributor
|
Cool! I would like to include this in the new fork of Beep. May I suggest to choose the channels in the following way depending on the available number of channels:
According to this and this the 1st and 3rd channels are the front left and front right channels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code no longer assumes Vorbis files are stereo (they may have up to 255 channels), which caused e.g. mono files to play at twice their speed.
The current strategy for files with more than 2 channels is to only play the first and last channels, and drop the rest.