Skip to content

team: add Ace McShane and orchestrator sub-region for The Doctor#28

Open
adrianwedd wants to merge 1 commit into
mainfrom
team/add-ace-and-doctor
Open

team: add Ace McShane and orchestrator sub-region for The Doctor#28
adrianwedd wants to merge 1 commit into
mainfrom
team/add-ace-and-doctor

Conversation

@adrianwedd
Copy link
Copy Markdown
Member

@adrianwedd adrianwedd commented May 10, 2026

Summary

  • Adds Ace McShane (Commercial & Communications Lead) as a peer companion, slotted before Sarah Jane to keep the outward-facing pair adjacent. Rust-orange palette (#e67e22). Portrait asset present.
  • Adds The Doctor in a structurally distinct sub-region after K-9 — not as a peer in the companion array. Companions are Tier-4 specialists; the orchestrator sits a tier above, and the design honours that asymmetry rather than flattening it.

The Doctor's sub-region (design choices)

  • Coordination divider — full-viewport typography-only break (deep teal palette) signalling tier shift before the profile lands.
  • Bespoke .the-doctor-section — its own card, monogram glyph (∞), no portrait, cooler indigo/teal palette to read as "above the companions."
  • He/him presented quietly via small footnote in-section — not a banner. The asymmetry is structural, doesn't need explanation on the page.
  • Skip-nav and dot-nav include The Doctor as a separate item.

Asset gaps requiring Adrian (flagged here for visibility)

  • The Doctor portrait — not yet commissioned. Section is portrait-less by design until one exists. HTML comment in the section marks the swap-in point (/images/companions/web_the-doctor.webp).
  • Companion intro audio (/audio/companions/*.ogg|mp3) does not exist for any companion yet — pattern degrades gracefully via the existing <audio> fallback, so Ace's ace_mcshane_intro entry follows the established convention.
  • Voice profile JSONs exist at afterwords/voices/the-doctor.json and afterwords/voices/ace.json — wiring through to public /audio/companions/ is a separate pipeline task not in scope here.

Notes

  • Build verification: full astro build is currently blocked on a pre-existing content-collection schema error in daily-paper/2026-05-09-sok-robustness...md (paperType systematization not in enum), introduced in commit f84f98a before this branch. Frontmatter JS in team.astro parses cleanly. Donna/Adrian: this is an orthogonal site-build issue worth fixing on main.
  • Meta description updated from "fourteen specialists" to "fifteen specialists … coordinated by an orchestrator role."
  • Single file changed: site/src/pages/about/team.astro (+300, -2). No other files touched.

Test plan

  • Donna QA pass on Ace's bio voice and Doctor's bio voice
  • Visual review: coordination divider reads as a clear tier break (not a fifth-wall companion section)
  • Mobile responsive check on .the-doctor-card and .coordination-divider-card
  • Skip-nav and dot-nav include The Doctor entry
  • Adrian: confirm Doctor portrait commissioning path and decide on portrait-less vs delayed merge
  • Pre-existing build error on daily-paper content schema is resolved on main before merging this branch (or accepted as known issue)

@adrianwedd
feat(team): add Ace McShane and orchestrator sub-region for The Doctor
beca96b 
Ace McShane (Commercial & Communications Lead) joins the companion roster
between Yaz/Tegan/Sarah Jane and K-9, paired adjacent to Sarah Jane (External
Relations) since both are outward-facing roles. Rust-orange palette
(#e67e22). Portrait already on disk at /images/companions/char_ace.webp.

The Doctor is added in a structurally distinct sub-region after K-9, not as
a peer in the companion array. The companions are Tier-4 specialists; the
orchestrator sits a tier above and the design honours that asymmetry:

- Coordination divider section (typography-only, deep teal palette)
  introduces the tier shift before the profile.
- Bespoke .the-doctor-section with its own card, monogram glyph, no
  portrait card (portrait not yet commissioned), and cooler indigo/teal
  palette to signal "above the companions."
- He/him pronouns presented quietly via a small footnote in-section, not a
  banner — the asymmetry is structural, not awkward.
- Skip-nav and dot-nav include The Doctor as a separate item.

Asset gaps flagged for follow-up:
- The Doctor portrait: not yet commissioned. Section is portrait-less by
  design until one exists (HTML comment marks the swap-in point).
- Companion intro audio (/audio/companions/*.ogg|mp3) does not exist for
  any companion yet — pattern degrades gracefully, so Ace's audio entry
  follows the same convention (ace_mcshane_intro).

Donna QA before merge per dispatch.
adrianwedd added a commit that referenced this pull request May 10, 2026
@adrianwedd @claude
fix(content): add 'systematization' to paperType enum
0da7af4 
Daily-paper schema was missing 'systematization' value, used in
2026-05-09-sok-robustness-large-language-models-jailbreak-attacks.md
and others. Caused astro build failures on main, blocking deploy
verification of in-flight PRs.

Discovered by River Song while reviewing PR #28. Pre-existing on main
from commit f84f98a; orthogonal to PR #28 but blocking its deploy.

Same fix also exists on the team/add-ace-and-doctor branch (PR #28);
landing on main directly so other in-flight branches benefit and
PR #28 review/merge isn't gated on this orthogonal fix.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
adrianwedd added a commit that referenced this pull request May 10, 2026
@adrianwedd
chore(deps): periodic dependabot sweep (build-time transitives) (#30)
1ab2ad8 
Adds an `overrides` block to site/package.json to pull build-time
transitive dependencies forward to patched versions. All packages here
are build-toolchain only — none ship to the browser from a static Astro
site, so dependabot's `scope:runtime` flag (just "in dependencies, not
devDependencies") is misleading for our build.

Per the 2026-05-11 dependabot triage
(research/intelligence/dependabot_failurefirst_triage_2026-05-11.md in
the private repo), this is the IGNORE-DEVDEP / IGNORE-NO-CONTEXT
hygiene sweep. The bump is hygiene, not risk reduction — none of these
attack vectors apply to a static-site `astro build` pipeline.

Closed alerts (GHSA → resolved version):
- #10  rollup            GHSA-mw96-cpmx-2vgc → 4.60.3 (^4.59.0)
- #11  fast-xml-parser   GHSA-fj3w-jwp8-x2g3 → 5.7.3  (^5.7.0)
- #12  svgo              GHSA-xpqw-6gx7-v673 → 4.0.1  (^4.0.1)
- #13  devalue           GHSA-cfw5-2vxh-hr84 → 5.8.0  (^5.6.4)
- #14  devalue           GHSA-mwv9-gp5h-frr4 → 5.8.0  (^5.6.4)
- #16  h3                GHSA-wr4h-v87w-p3r7 → 1.15.11 (^1.15.9, 1.x backport)
- #17  h3                GHSA-22cc-p3c6-wpvm → 1.15.11 (^1.15.9, 1.x backport)
- #19  h3                GHSA-72gr-qfp7-vwhw → 1.15.11 (^1.15.9)
- #20  h3                GHSA-4hxc-9384-m385 → 1.15.11 (^1.15.9, 1.x backport)
- #21  fast-xml-parser   GHSA-8gc5-j5rx-235r → 5.7.3  (^5.7.0)
- #23  picomatch         GHSA-c2c7-rcm5-vvqj → 4.0.4  (^4.0.4)
- #24  picomatch         GHSA-3v7f-55p6-f55p → 4.0.4  (^4.0.4)
- #26  picomatch         GHSA-c2c7-rcm5-vvqj → 2.3.2  (^2.3.2, 2.x line)
- #27  picomatch         GHSA-3v7f-55p6-f55p → 2.3.2  (^2.3.2, 2.x line)
- #28  defu              GHSA-737v-mqg7-c878 → 6.1.7  (^6.1.5)
- #29  vite              GHSA-p9ff-h696-f583 → 6.4.2  (^6.4.2, 6.x backport)
- #30  fast-xml-parser   GHSA-jp2q-39xq-3w4g → 5.7.3  (^5.7.0)
- #31  vite              GHSA-4w7w-66w2-5vf9 → 6.4.2  (^6.4.2, 6.x backport)
- #34  fast-xml-parser   GHSA-gh4j-gqv2-49f6 → 5.7.3  (^5.7.0)
- #35  postcss           GHSA-qx2v-qp2m-jg93 → 8.5.14 (^8.5.10)

Notes on dependabot fix-version vs override-target divergence:
- vite: dependabot lists fix=8.0.5 (the latest line); 6.4.2 is the
  in-line backport per the GHSA advisory (`>= 6.4.2` patches the 6.x
  line). We stay on vite 6 because Astro 5 pulls vite 6.
- h3: dependabot lists 2.0.1-rc.15; we use 1.15.9 per the GHSA
  advisory (`>= 1.15.6` and `>= 1.15.9` are the documented 1.x
  backports). h3 2.x is still rc.
- picomatch: split override (^2 and ^4) because both major lines are
  pulled in transitively by separate consumers; both have CVEs.

Deferred (NEEDS-REVIEW, separate PR):
- #33 astro define:vars XSS — requires Astro 6 major bump, deferred
  pending define:vars usage audit.

Verification:
- npm install — clean
- npm run build — 1137 pages, build complete, no errors
- npm audit — 1 moderate (the deferred Astro 6 alert) remaining
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adrianwedd