Feature/axis name generation handle missing info#681
Open
dedeibel wants to merge 2 commits intofair-acc:mainfrom
Open
Feature/axis name generation handle missing info#681dedeibel wants to merge 2 commits intofair-acc:mainfrom
dedeibel wants to merge 2 commits intofair-acc:mainfrom
Conversation
dedeibel
force-pushed
the
feature/axis-name-generation-handle-missing-info
branch
from
189ebd9 to
667f345
Compare
- Remove leading white space when a unit was present but no axis name - Use an empty label if no axis name was specified and the unit was an empty string - Extracted axis label generator to own method for easier overwrite
dedeibel
force-pushed
the
feature/axis-name-generation-handle-missing-info
branch
from
667f345 to
9cfa75b
Compare
- Remove throws exception for quality gate
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am suggesting this change since I noticed two "problems" with the axis label handling.
_[V](Space replaced by _ in the example)[]The change would result in the following behaviour (taken from the tests):
In our code we extended
DefaultNumericAxisbecause of this. With the changes this would not be necessary.Please consider the above suggestion for integration.