Bugfix/705 zoomer plugin issues with inverted axes#706
Bugfix/705 zoomer plugin issues with inverted axes#706dedeibel wants to merge 5 commits intofair-acc:mainfrom
Conversation
And do not reset inverted setting of x axis when adding the chart.
The cached offset was overwritten by a possibly older method to calculate it which was not usable on the first run of calculations.
| logScaleLengthInv = axisLength / logScaleLength; | ||
| offset = axisLength; | ||
|
|
||
| offset = isVerticalAxis ? getHeight() : getWidth(); |
There was a problem hiding this comment.
Maybe a left over of the bigger changes lately. axisLength from line 606 is already populated during initial rendering while getWidth() seems to be zero and causes the inverted axis to be not placed properly.
| setPrefWidth(-1); | ||
| setMaxWidth(Double.MAX_VALUE); | ||
|
|
||
| xAxis.invertAxisProperty().bindBidirectional(invertedSlide); |
There was a problem hiding this comment.
This did set xAxis.invertAxisProperty() to false for an axes that was already inverted before adding the zoomer plugin (invertedSlide is initially false).
Bidirectional binding was not required here IMO.
| chart6.getFirstAxis(Orientation.VERTICAL).invertAxis(true); | ||
| final Zoomer zoomer6 = new Zoomer(); | ||
| registerZoomerChangeListener(zoomer6, chart6.getTitle()); | ||
| chart6.getPlugins().add(zoomer6); |
There was a problem hiding this comment.
For reproduction according to Jonas' report.
|
dedeibel
changed the title
|
Any news on this? |
|
Is there an estimate on when you might get to looking at the PR? |
2 participants
Fixes #705 and related problems.
@wirew0rm could you please review and accept these changes.