fix build on jdk21-25

chartfx-chart/pom.xml

@@ -101,6 +101,17 @@
 
     <build>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-javadoc-plugin</artifactId>
+                <configuration>
+                    <additionalOptions>
+                        <option>--add-exports=javafx.graphics/com.sun.javafx.tk=${project.moduleName}</option>
+                        <option>--add-exports=javafx.controls/com.sun.javafx.scene.control.skin=${project.moduleName}</option>
+                        <option>--add-exports=org.controlsfx.controls/impl.org.controlsfx.skin=${project.moduleName}</option>
+                    </additionalOptions>
+                </configuration>
+            </plugin>
             <plugin> <!-- Converts Sass files to CSS -->
                 <groupId>us.hebi.sass</groupId>
                 <artifactId>sass-cli-maven-plugin</artifactId>

chartfx-chart/src/main/java/io/fair_acc/chartfx/ui/ObservableDeque.java

@@ -280,4 +280,20 @@ public E pop() {
     public Iterator<E> descendingIterator() {
         return deque.descendingIterator();
     }
+
+    /**
+     * Unsupported: we need to override this method because of a name clash between
+     * java.util.List and java.util.Deque. Both define a method called reversed() but with
+     * different return types. This method was introduced in Java 21. Read more about it here:
+     * https://inside.java/2023/05/12/quality-heads-up/
+     */
+    public ObservableDeque<E> reversed() {
+        /*
+         * Throw an exception. A better solution would be a complete implementation
+         * of a reversed observable deque. However, that is quite a bit of work and if not needed
+         * then why do it. To see an example for this approach, see LinkedList.reversed().
+         */
+        throw new UnsupportedOperationException("reversed() not supported");
+    }
+
 }

chartfx-samples/pom.xml

@@ -75,6 +75,16 @@
 
     <build>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-javadoc-plugin</artifactId>
+                <configuration>
+                    <additionalOptions>
+                        <option>--add-exports=javafx.graphics/com.sun.javafx.scene=${project.moduleName}</option>
+                        <option>--add-exports=javafx.graphics/com.sun.javafx.tk=${project.moduleName}</option>
+                    </additionalOptions>
+                </configuration>
+            </plugin>
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>exec-maven-plugin</artifactId>

chartfx-samples/src/main/java/io/fair_acc/sample/ChartFxDatasetSamplerProject.java

@@ -9,31 +9,22 @@
 import fxsampler.model.WelcomePage;
 
 public class ChartFxDatasetSamplerProject implements FXSamplerProject {
-    /**
-     * {@inheritDoc}
-     */
+
     @Override
     public String getProjectName() {
         return "ChartFx - Datasets";
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public String getSampleBasePackage() {
         return "io.fair_acc.sample.dataset";
     }
 
-    ///** {@inheritDoc} */
     //@Override
     // public String getModuleName() {
     //    return "io.fair-acc";
     //}
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public WelcomePage getWelcomePage() {
         VBox vBox = new VBox();

chartfx-samples/src/main/java/io/fair_acc/sample/ChartFxFinancialSamplerProject.java

@@ -9,31 +9,22 @@
 import fxsampler.model.WelcomePage;
 
 public class ChartFxFinancialSamplerProject implements FXSamplerProject {
-    /**
-     * {@inheritDoc}
-     */
+
     @Override
     public String getProjectName() {
         return "ChartFx - Financial Plots";
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public String getSampleBasePackage() {
         return "io.fair_acc.sample.financial";
     }
 
-    ///** {@inheritDoc} */
     //@Override
     // public String getModuleName() {
     //    return "io.fair-acc";
     //}
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public WelcomePage getWelcomePage() {
         VBox vBox = new VBox();

chartfx-samples/src/main/java/io/fair_acc/sample/ChartFxMathSamplerProject.java

@@ -9,31 +9,22 @@
 import fxsampler.model.WelcomePage;
 
 public class ChartFxMathSamplerProject implements FXSamplerProject {
-    /**
-     * {@inheritDoc}
-     */
+
     @Override
     public String getProjectName() {
         return "ChartFx - Math";
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public String getSampleBasePackage() {
         return "io.fair_acc.sample.math";
     }
 
-    ///** {@inheritDoc} */
     //@Override
     // public String getModuleName() {
     //    return "io.fair-acc";
     //}
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public WelcomePage getWelcomePage() {
         VBox vBox = new VBox();

chartfx-samples/src/main/java/io/fair_acc/sample/ChartFxMiscSamplerProject.java

@@ -9,31 +9,23 @@
 import fxsampler.model.WelcomePage;
 
 public class ChartFxMiscSamplerProject implements FXSamplerProject {
-    /**
-     * {@inheritDoc}
-     */
+
     @Override
     public String getProjectName() {
         return "ChartFx - Misc";
     }
 
-    /**
-     * {@inheritDoc}
-     */
+
     @Override
     public String getSampleBasePackage() {
         return "io.fair_acc.sample.misc";
     }
 
-    ///** {@inheritDoc} */
     //@Override
     // public String getModuleName() {
     //    return "io.fair-acc";
     //}
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public WelcomePage getWelcomePage() {
         VBox vBox = new VBox();

chartfx-samples/src/main/java/io/fair_acc/sample/ChartFxSamplerProject.java

@@ -21,31 +21,22 @@
 import fxsampler.model.WelcomePage;
 
 public class ChartFxSamplerProject implements FXSamplerProject {
-    /**
-     * {@inheritDoc}
-     */
+
     @Override
     public String getProjectName() {
         return "ChartFx";
     }
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public String getSampleBasePackage() {
         return "io.fair_acc.sample.chart";
     }
 
-    ///** {@inheritDoc} */
     //@Override
     // public String getModuleName() {
     //    return "io.fair-acc";
     //}
 
-    /**
-     * {@inheritDoc}
-     */
     @Override
     public WelcomePage getWelcomePage() {
         VBox vBox = new VBox();

chartfx-samples/src/main/java/io/fair_acc/sample/LaunchJFX.java

@@ -19,8 +19,7 @@
  * "Variable", "${project_classpath}", but there is no way to add the current projects dependencies to the classpath,
  * yet.
  *
- * @see <a href="https://stackoverflow.com/a/55300492" target="_top"> Stackoverflow: How to add JavaFX runtime to
- *      Eclipse in Java11 (2b) </a>
+ * See <a href="https://stackoverflow.com/a/55300492">Stackoverflow: How to add JavaFX runtime to Eclipse in Java11 (2b)</a>
  * @author akrimm
  */
 public class LaunchJFX { // NOMEN EST OMEN

chartfx-samples/src/main/java/io/fair_acc/sample/dataset/legacy/DoubleDataSet.java

@@ -17,7 +17,7 @@
  * User provides X and Y coordinates or only Y coordinates. In the former case X coordinates have value of data point
  * index. This version being optimised for native double arrays.
  *
- * @see DoubleErrorDataSet for an equivalent implementation with asymmetric errors in Y
+ * Check {@link DoubleErrorDataSet} for an equivalent implementation with asymmetric errors in Y
  * @author rstein
  * @deprecated this is kept for reference/performance comparisons only
  */

chartfx-samples/src/main/java/io/fair_acc/sample/dataset/legacy/DoubleErrorDataSet.java

@@ -14,7 +14,7 @@
  * User provides X and Y coordinates or only Y coordinates. In the former case X coordinates have value of data point
  * index. This version being optimised for native double arrays.
  *
- * @see DoubleDataSet for an equivalent implementation without errors
+ * Check {@link DoubleDataSet} for an equivalent implementation without errors
  * @author rstein
  * @deprecated this is kept for reference/performance comparisons only
  */

chartfx-samples/src/main/java/io/fair_acc/sample/financial/service/ConcurrentDateFormatAccess.java

@@ -6,7 +6,7 @@
 import java.util.Date;
 
 /**
- * @see SimpleDateFormat is not thread safe. For parallel processing of data streams is necessary to use threadlocal processing.
+ * Note: {@link SimpleDateFormat} is not thread safe. For parallel processing of data streams is necessary to use threadlocal processing.
  */
 public class ConcurrentDateFormatAccess {
     private final String simpleDateFormatString;

chartfx-samples/src/main/java/io/fair_acc/sample/financial/service/SCIDByNio.java

@@ -288,9 +288,7 @@ private Date loadTimestamp(long position) throws IOException {
     }
 
     /**
-     * Thanks to @see
-     * http://svn.codehaus.org/groovy/modules/scriptom/branches/SCRIPTOM
-     * -1.5.4-ANT/src/com/jacob/com/DateUtilities.java
+     * Thanks to <a href="http://svn.codehaus.org/groovy/modules/scriptom/branches/SCRIPTOM-1.5.4-ANT/src/com/jacob/com/DateUtilities.java">DateUtilities.java</a>
      *
      * @param comTime time in windows time for convert to java format
      * @return java format of windows format with usage of specific timezone

pom.xml

@@ -150,12 +150,13 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-javadoc-plugin</artifactId>
-                    <version>3.0.1</version> <!-- use old version to ignore module system errors -->
+                    <version>3.6.3</version>
                     <configuration>
+                        <source>17</source>
                         <links>
                             <link>https://openjfx.io/javadoc/12/</link>
                         </links>
-                        <doclint>none</doclint> <!-- TODO: fix javadoc errors -->
+                        <doclint>none</doclint> <!-- Prevents minor HTML errors from breaking the build -->
                     </configuration>
                     <executions>
                         <execution>
@@ -362,6 +363,20 @@
     </dependencies>
 
     <profiles>
+        <profile>
+            <id>disable-javadoc-on-jdk25</id>
+            <activation>
+                <jdk>[25,)</jdk> <!-- >= jdk25 -->
+            </activation>
+            <properties>
+                <!--
+                javadoc25 got really strict and crashes on 'samples', but the error message
+                does not say why. It's unlikely that we need javadoc for non-release builds,
+                so we can just disable it until we know the cause.
+                  -->
+                <maven.javadoc.skip>true</maven.javadoc.skip>
+            </properties>
+        </profile>
         <profile>
             <id>releaseGithub</id>
             <activation>