Skip to content

Add explicit entity indexing and fix warehouse robot workflow#7

Open
falloficaruss wants to merge 1 commit into
mainfrom
meta-agent-identity-registry
Open

Add explicit entity indexing and fix warehouse robot workflow#7
falloficaruss wants to merge 1 commit into
mainfrom
meta-agent-identity-registry

Conversation

@falloficaruss

Copy link
Copy Markdown
Owner

Thanks for opening a PR! Please click the Preview tab and select a PR template:

Feature/enhancement PRs require prior maintainer approval in an issue or discussion before they are accepted.

@falloficaruss

Copy link
Copy Markdown
Owner Author

I guess the failing tests are from the mesa-examples

@github-actions

Copy link
Copy Markdown

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔴 +14.9% [+14.2%, +15.6%] 🔵 -2.9% [-3.1%, -2.7%]
BoltzmannWealth large 🔴 +16.0% [+15.0%, +16.9%] 🔵 +4.6% [+1.0%, +8.2%]
Schelling small 🔴 +10.7% [+10.0%, +11.5%] 🔵 +1.2% [+0.3%, +2.1%]
Schelling large 🔴 +7.5% [+6.8%, +8.1%] 🔵 +0.9% [-1.5%, +3.1%]
WolfSheep small 🔴 +20.3% [+19.8%, +20.8%] 🔵 +6.8% [+2.1%, +11.7%]
WolfSheep large 🔴 +20.6% [+18.9%, +22.3%] 🔴 +16.9% [+14.0%, +20.0%]
SugarscapeG1mt small 🔵 +1.8% [+1.2%, +2.3%] 🔵 +1.6% [-0.1%, +3.4%]
SugarscapeG1mt large 🔵 +1.0% [-0.5%, +2.6%] 🔵 -1.5% [-3.8%, +0.7%]
BoidFlockers small 🔴 +21.5% [+20.9%, +22.0%] 🔵 -0.3% [-0.7%, +0.2%]
BoidFlockers large 🔴 +23.9% [+22.9%, +24.9%] 🔵 -0.5% [-1.1%, +0.2%]

@@ -229,11 +230,15 @@ def add_attributes(
# Prevent collision of attributes with meta-agent instantiation
mesa_primitives = [

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to wrap my head around the identity set up, but it looks promising. However this was a brittle stop gap. If there is a change to a mesa attribute, this will break or more likely be forgotten about and then a bug will be introduced. So, we we want generate this form the mesa classes. This way if there is ever a change later on it will automatically update.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was intended to be temporary. I sense we have come to a sort of pivotal point where I would like to discuss about the future implementation of the Facade API and Meta-Agents in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants