⚡ Optimize redundant strlen in loop condition#197
⚡ Optimize redundant strlen in loop condition#197google-labs-jules[bot] wants to merge 1 commit intomasterfrom
Conversation
- Moved `strlen` calculation out of the loop in `sanitise_LinkTable` function. - This prevents re-calculating the string length on every iteration, changing the complexity from O(N^2) to O(N) for string processing. - Benchmarks showed a ~5.6x improvement for strings of length 250.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
1 participant
This PR optimizes a loop in
src/sonic.cwherestrlenwas called in the loop condition. By moving thestrlencall outside the loop, we avoid redundant calculations, improving performance for sanitizing link names.Benchmarking with 100,000 links of length 250 showed a reduction in processing time from ~0.20s to ~0.036s (5.6x speedup).
PR created automatically by Jules for task 13137236028223471761 started by @fangfufu