Fix nmsgtool compiler warning when building without rdkafka/json-c#181
Open
Fix nmsgtool compiler warning when building without rdkafka/json-c#181
Conversation
shw700
reviewed
Feb 12, 2026
| fprintf(stderr, "%s: Error: nmsg protocol must be set for Kafka topic\n", | ||
| argv_program); | ||
| #endif /* HAVE_JSON_C */ | ||
| exit(EXIT_FAILURE); |
Contributor
There was a problem hiding this comment.
It's a bit weird, but these calls to exit() must be kept here for internal consistency with the rest of the helper functions that also call exit(1) in the event of an error... it's done a million places in src/io.c ...
shw700
reviewed
Feb 12, 2026
| fprintf(stderr, "%s: Error: nmsg protocol must be set for Kafka topic\n", | ||
| argv_program); | ||
| #endif /* HAVE_JSON_C */ | ||
| exit(EXIT_FAILURE); |
Author
There was a problem hiding this comment.
I added back the exit(EXIT_FAILURE) for both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed guards around function calls, which was causing unused function warning.
Tests were failing when json-c was disabled because they unconditionally called json-related functions that weren't available. This PR adds conditional test execution by exporting a
USE_JSONvariable from the build system and wrapping all json-dependent operations in conditionals across all tests. When json-c is disabled, tests now execute no-op commands followed by check calls to properly register as passing rather than failing on unavailable functions.