switch to case-insensitive http header comparisons, also fix racing in linux.jai#2
Open
DaseinPhaos wants to merge 2 commits intofarzher:masterfrom
Open
switch to case-insensitive http header comparisons, also fix racing in linux.jai#2DaseinPhaos wants to merge 2 commits intofarzher:masterfrom
DaseinPhaos wants to merge 2 commits intofarzher:masterfrom
Conversation
Author
|
Also, the crashing issue you mentioned might be related to the racing issue when accessing However, I don't have a beefy ubuntu server with a lot of threads to properly test it. Testing with But it's certainly not crashing anymore! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome package!
This PR fixes a tiny issue wrt http header comparisons. According to the mdn reference:
But the previous parsing code used hard-coded literals when parsing specific headers, resulting in some requests not being correctly parsed. This PR fixes that.