feat: add pagination limits to user and item list endpoints#2383
Open
HassanRady wants to merge 1 commit into
Open
feat: add pagination limits to user and item list endpoints#2383HassanRady wants to merge 1 commit into
HassanRady wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Discussion:
Description
Currently, pagination routes accept an arbitrary
limitparameter without validation (e.g.,limit: int = 100). At scale, a client or malicious user could supply an extremely large limit (e.g.,?limit=1000000).FastAPI and SQLModel will read all matching records from the database and instantiate them as Python objects in the server's heap memory. This results in:
The Remediation Code
Use FastAPI's
Queryparameter validator to enforce a hard maximum limit (le=100). This rejects invalid requests with a422 Unprocessable Entityvalidation error before querying the database.Checklist