build(deps): replace proxy-addr with @fastify/proxy-addr#5913
Merged
Conversation
|
Node: 20 Node: 22 |
|
Node: 20 Node: 22 |
Member
|
Fastify version bench: > /Users/gurgunday/.nvm/versions/node/v22.12.0/bin/node benchmark/compiling.js
2 tests completed.
re-compiling x 266,204 ops/sec ±1.59% (192 runs sampled)
pre-compiling x 1,378,355 ops/sec ±0.26% (197 runs sampled)
> /Users/gurgunday/.nvm/versions/node/v22.12.0/bin/node benchmark/kind.js
3 tests completed.
ipv4 x 1,434,307 ops/sec ±1.45% (192 runs sampled)
ipv4-mapped x 437,080 ops/sec ±0.09% (196 runs sampled)
ipv6 x 554,847 ops/sec ±1.43% (195 runs sampled)
> /Users/gurgunday/.nvm/versions/node/v22.12.0/bin/node benchmark/matching.js
6 tests completed.
trust none x 22,475,003 ops/sec ±1.70% (190 runs sampled)
trust all x 46,984,338 ops/sec ±0.56% (195 runs sampled)
trust single x 1,434,945 ops/sec ±1.41% (195 runs sampled)
trust first x 46,407,961 ops/sec ±0.53% (191 runs sampled)
trust subnet x 1,460,830 ops/sec ±0.10% (195 runs sampled)
trust multiple x 1,441,307 ops/sec ±1.34% (197 runs sampled)original: > /Users/gurgunday/.nvm/versions/node/v22.12.0/bin/node benchmark/compiling.js
2 tests completed.
re-compiling x 288,284 ops/sec ±1.37% (195 runs sampled)
pre-compiling x 1,524,601 ops/sec ±0.95% (193 runs sampled)
> /Users/gurgunday/.nvm/versions/node/v22.12.0/bin/node benchmark/kind.js
3 tests completed.
ipv4 x 1,501,259 ops/sec ±1.68% (196 runs sampled)
ipv4-mapped x 433,521 ops/sec ±0.42% (196 runs sampled)
ipv6 x 518,953 ops/sec ±1.39% (195 runs sampled)
> /Users/gurgunday/.nvm/versions/node/v22.12.0/bin/node benchmark/matching.js
6 tests completed.
trust none x 7,870,762 ops/sec ±1.36% (191 runs sampled)
trust all x 9,507,996 ops/sec ±1.41% (195 runs sampled)
trust single x 1,507,601 ops/sec ±0.11% (193 runs sampled)
trust first x 9,572,051 ops/sec ±1.34% (197 runs sampled)
trust subnet x 1,570,250 ops/sec ±0.08% (196 runs sampled)
trust multiple x 1,541,185 ops/sec ±1.24% (197 runs sampled) |
gurgunday
approved these changes
Dec 28, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in fastify/proxy-addr#52,
@fastify/proxy-addris faster thanproxy-addrdue to the@fastify/forwardedfork.Checklist
npm run testandnpm run benchmarkand the Code of conduct