Merged
Conversation
|
Reviewersにアサインされましたが宛先ミスですかね |
Author
|
@naoyamada-fastlabel |
Contributor
|
@daisuke-miyazoe @soymd |
Author
|
@rikunosuke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
サマリ
概要、背景
タスクに紐づくコメントを取得する API メソッド
get_commentsを追加する。(不具合の場合のみ) 発生原因
対応内容
やったこと
Clientクラスにget_commentsメソッドを追加project(プロジェクト名)とtask_id(タスクID)を指定してコメント一覧を取得offset/limitによるページネーションに対応limitが 1000 を超える場合はFastLabelInvalidExceptionを送出やれていないこと、妥協点
UI/UX
before
after
テスト
変更の意図に沿った基本動作が確認できている
get_comments(project, task_id)でコメント一覧が取得できるoffset/limitを指定してページネーションが動作する関連する既存機能にデグレがないことを確認
get_histories等の周辺メソッドが正常に動作するエッジケースや例外パターンの動作を確認
limitに 1001 以上を指定した場合にFastLabelInvalidExceptionが発生する関連リンク
補足