Open
Conversation
iwaneshuhei
force-pushed
the
feature/internal-extension
branch
from
18bef3b to
431c302
Compare
iwaneshuhei
force-pushed
the
feature/internal-extension
branch
from
431c302 to
b811379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change RequestManager
urlのパターンがRequestManagerだと、ファイル名しか変更できないため、拡張して各コンテンツごとにURLを解決できるようにする
support NodeDecorator
Potreeのデータは静的な巨大なファイルを、byteのrange指定で取得するので、アノテーションの情報は、識別キーと一緒に同一粒度(node)単位で、保存しているためその繁栄のために、NodeDecoratorを差し込めるようにする
rgba BufferAttribute の色をアノテーションの色で塗り替える
BufferAttribute追加[anno_idx]
アノテーションを区別する為に追加
BufferAttribute追加[bk_rgba]
色のクリア時に、戻しやすくするために bk_rgba を追加する
NodeLoader load に完了時のcallbackを追加
load の Promiseは、ワーカーにPOSTするまでになっているため、完了時のタイミングとれないため、追加
Comment