Write diagnostic warnings to stderr instead of stdout#1682
Open
Write diagnostic warnings to stderr instead of stdout#1682
Conversation
Expiration warnings, profile-not-found warnings, and config permission warnings were written to data.Output (stdout), breaking JSON parsing when --json was used.
Member
philippschulte
left a comment
There was a problem hiding this comment.
Do the tests really verify the regression, because most of them set ErrOutput to the same buffer as Output. I don't think they catch accidental writes to stdout.
Maybe it would be good to add a test with separate stdout/stderr buffers and assert that warnings land only in stderr while stdout remains valid JSON?
Contributor
Author
Added, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Expiration warnings, profile-not-found warnings, and config permission warnings were written to
stdout,which broke JSON parsing when--jsonwas used. Now warnings go to stderr instead.All Submissions:
Changes to Core Features:
User Impact
Users piping CLI output through
jqor other JSON parsers will no longer encounter parse errors caused by diagnostic warnings mixed intostdout.Are there any considerations that need to be addressed for release?
No breaking changes.