track: add into_inner#48370
Closed
jkarneges wants to merge 1 commit into
Closed
Conversation
Member
Author
|
CI failing due to the code not being used yet. Will just put it in the PR that uses it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
trackmodule is used to enforce lifetimes of IPC messages, such that only one such tracked message exists at a time per task and that the message is processed timely. For the upcoming work to send large response headers, we'll need to keep the backing message around longer than usual so it can be borrowed while its contents are being sent to the client. This PR adds aninto_innermethod toTrack, making it possible for a task to optionally exclude a message from tracking.Note: we didn't need this for sending large request headers to the server, since the source message for outbound requests already begins in an untracked state.