Fix updating dynamic optimizer flows#1481
Merged
vloncar merged 5 commits intoJun 7, 2026
Merged
Conversation
Contributor
Author
|
pre-commit.ci autofix |
vloncar
approved these changes
Jun 7, 2026
Contributor
vloncar
left a comment
vloncar
left a comment
There was a problem hiding this comment.
Indeed a bug. I can't remember what was the idea behind using put() here. Seemed unused for many years
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes dynamic flow updates by using the correct
set.add()API when recording added or removed optimizers.Previously, calling update_flow() on a callable-backed flow raised an AttributeError because dynamic flow attempted to call
set.put(). Callable backed flows are used for dynamic optimizer/template flow registration, so this broke flow customization for those flows.Also adds a focused regression test covering add/remove behavior for a dynamic flow.
Type of change
Bug fix
Tests
i added a regression test in
test/pytest/test_flows.pyfor updating a dynamic flow.Test command;