fix: remove unused use tauri::Manager import#4587
Open
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Open
fix: remove unused use tauri::Manager import#4587devin-ai-integration[bot] wants to merge 3 commits intomainfrom
use tauri::Manager import#4587devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Conversation
- Auto-fixed: simplify closures, remove unnecessary clones, use map_or - Manual fix: collapse nested if-let in recorder.rs sync_dir - Manual fix: remove unused import tauri::Manager in desktop lib.rs - Add plugins/cli2 to workspace exclude (no Cargo.toml, JS-only plugin) Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
bot
changed the title
use tauri::Manager import
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
use tauri::Managerimport fromapps/desktop/src-tauri/src/lib.rs, as flagged bycargo clippyon Linux.Review & Testing Checklist for Human
use tauri::Manageris not needed for macOS-gated code. TheManagertrait provides methods like.webview_windows()and.set_activation_policy()used inside#[cfg(target_os = "macos")]blocks (~line 264). Clippy ran on Linux and cannot see inside macOS cfg blocks. Confirm thatuse ext::*or another import bringsManagerinto scope, or restore the import.Notes
tauri::Managermay be required by macOS-only code paths that clippy on Linux cannot analyze.Link to Devin session: https://app.devin.ai/sessions/423041396aaf4dfc829d7669170f7a88