fix: remove hold-to-quit from the macOS quit flow#4597
Merged
ComputelessComputer merged 1 commit intomainfrom Mar 16, 2026
Merged
fix: remove hold-to-quit from the macOS quit flow#4597ComputelessComputer merged 1 commit intomainfrom
ComputelessComputer merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for hyprnote-storybook canceled.
|
❌ Deploy Preview for hyprnote failed.
|
ComputelessComputer
requested review from
goranmoomin and
yujonglee
and removed request for
goranmoomin and
yujonglee
- change Cmd+Q interception to require a second press for a full quit - replace the two-option quit overlay with a single "press again to quit" prompt - remove the old close/hide handler path and align the app menu quit action with Cmd+Q
ComputelessComputer
force-pushed
the
c-branch-8
branch
from
7c82fde to
6b639e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reasoning: if someone is hitting
CMD+Q, that means they probably want to quit the app and expect it to be not running in the background. it's nice to have a confirmation dialog, but we shouldn't confuse the user with two diverged paths.