[PVM-host] Enforce parallel accumulation service ID conflict rules using base snapshot#367
Merged
[PVM-host] Enforce parallel accumulation service ID conflict rules using base snapshot#367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up on #366.
According to the Graypaper, service IDs newly added or removed in the same parallel accumulation round must not conflict across different accumulate hosts. Reuse across different rounds is allowed (e.g., and ID removed in round 1 can be added in round 2).
Previously, the merge logic of single-service accumulations did not distinguish base state from same-round changes, which caused prior-round removals to be treated as conflicts in the current round.
This PR adds sets to track "base-state" vs "this-round" service ID changes when merging the accumulation results.