feat(weather): allow manual latitude/longitude input#640
Open
saulob wants to merge 5 commits intofatihak:mainfrom
Open
feat(weather): allow manual latitude/longitude input#640saulob wants to merge 5 commits intofatihak:mainfrom
saulob wants to merge 5 commits intofatihak:mainfrom
Conversation
- Remove readonly attribute from latitude and longitude inputs so users can type coordinates directly without using the map picker - Re-read coordinate inputs when opening the map modal so manually entered values are respected; validated with Number.isFinite - Recalculate zoom level based on whether coordinates are present, matching mini_weather behavior (4.5 if set, 2.5 if not) - Reinitialize map view and marker position when the map is already initialized and reopened with updated coordinates
There was a problem hiding this comment.
Pull request overview
This PR updates the Weather plugin settings UI to support manually entering latitude/longitude while keeping the existing Leaflet map picker workflow.
Changes:
- Makes latitude/longitude inputs editable (removes
readonly). - Re-reads and syncs lat/long from inputs when opening the map modal, and refreshes the map view/marker on reopen.
- Adjusts how saved settings populate the coordinate fields.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 4 commits
March 28, 2026 12:48
Author
|
All Copilot review comments addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the Weather plugin by allowing users to manually input latitude and longitude, instead of relying only on the map picker.
This change was inspired by the feature request discussed here: #564
What was done
Why this matters
Additional Notes
Screenshots