Skip to content

Fix integration test retry for single test runners#4828

Open
gizmoguy wants to merge 1 commit into
faucetsdn:mainfrom
gizmoguy:fix-single-integration-test-retry
Open

Fix integration test retry for single test runners#4828
gizmoguy wants to merge 1 commit into
faucetsdn:mainfrom
gizmoguy:fix-single-integration-test-retry

Conversation

@gizmoguy

@gizmoguy gizmoguy commented Jul 17, 2026

Copy link
Copy Markdown
Member

#4496 added default retries for integration test runners, this worked for parallel test runners, but for the single test runners this crash was introduced:

FAILED (failures=1)
Traceback (most recent call last):
  File "/faucet-src/tests/integration/./mininet_main.py", line 19, in <module>
    test_main([mininet_tests.__name__, mininet_multidp_tests.__name__])
  File "/faucet-src/clib/clib_mininet_test_main.py", line 1069, in test_main
    run_tests(
  File "/faucet-src/clib/clib_mininet_test_main.py", line 805, in run_tests
    all_successful = run_test_suites(
                     ^^^^^^^^^^^^^^^^
  File "/faucet-src/clib/clib_mininet_test_main.py", line 665, in run_test_suites
    run_single_test_suites(debug, root_tmpdir, resultclass, single_tests, retries)
  File "/faucet-src/clib/clib_mininet_test_main.py", line 586, in run_single_test_suites
    test_results = single_runner.run(single_tests)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/unittest/runner.py", line 217, in run
    test(result)
  File "/usr/lib/python3.11/unittest/suite.py", line 84, in __call__
    return self.run(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/unittest/suite.py", line 122, in run
    test(result)
TypeError: 'NoneType' object is not callable

This patch provides each single test runner a fresh copy of the tests object to prevent a test runner from modifying the object which causes a subsequent runner to crash.

@gizmoguy gizmoguy changed the title Fix integration test retry for the single test runner Fix integration test retry for single test runners Jul 17, 2026
@gizmoguy
gizmoguy force-pushed the fix-single-integration-test-retry branch from b0f1777 to fff8227 Compare July 17, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant