feat: add --output filename option#88
Open
code-distortion wants to merge 1 commit intofboulnois:mainfrom
Open
Conversation
f55d769 to
7d559de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @fboulnois. I hope you don't mind me making this pull request. I wanted to give this a go to see if I could do it, and thought you might find it useful as well.
Synopsis
This pull request adds a new
--output xxxoption, to allow the user to specify a filename to output to.I wanted to let the caller specify this. This way, when programmatically calling
./build.sh run, the calling script knows exactly which output file to look for.Usage
./build.sh run 'a person riding a bicycle on a bridge' --output my_file.pngNotes
.pngfilenames (an exception is raised otherwise)output file: my_file.png__n_1,__n_2, etc) regardless of whether the user specified their own filename or not, but only when creating more than one image (i.e.--iters> 1 or--samples> 1)README.mdhas been updated