[#389][FIX] 모임별 약속 탭 카운트 및 전체 목록 조회 오류 수정#388
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 요약
이슈 번호
주요 변경 사항
getMeetingTabCounts(): 탭 카운트 3개 수정all: CONFIRMED만 → CONFIRMED + DONE 합산 (countByGatheringIdAndMeetingStatusIn신규 추가)upcoming: 3일 이내 제한 제거 → 전체 CONFIRMED 수 (countByGatheringIdAndMeetingStatus(CONFIRMED))joined: DONE 참여만 → 전체 상태 참여 수 (countMeetingsByUserIdAndGatheringId신규 추가)getAllMeetingsPage():filter=ALL시 CONFIRMED만 → CONFIRMED + DONE 반환 (findByGatheringIdAndMeetingStatusIn신규 추가)getUpcomingMeetingsPage(): 3일 이내 제한 제거 → 전체 CONFIRMED 반환 (기존findByGatheringIdAndMeetingStatus재활용)MeetingServiceTest: 변경된 로직에 맞게 mock 및 검증 업데이트참고 사항
all=0, done=8, joined=8→all < joined논리 불일치all = upcoming + done,joined ≤ allall < joined)filter=ALLCONFIRMED만 반환)