fix: properly apply cropArea to SCStreamConfiguration#1
Open
giorgio-zamparelli wants to merge 10 commits intofchevallieratecna:mainfrom
Open
fix: properly apply cropArea to SCStreamConfiguration#1giorgio-zamparelli wants to merge 10 commits intofchevallieratecna:mainfrom
giorgio-zamparelli wants to merge 10 commits intofchevallieratecna:mainfrom
Conversation
giorgio-zamparelli
force-pushed
the
main
branch
from
3c77fac to
e6c37f2
Compare
Allows specifying a custom output file path instead of using a temporary file. If not specified, falls back to temp file behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Rename audioDeviceId (string) to captureSystemAudio (boolean) - System audio is now disabled by default - Remove unused device ID validation since it's just a flag - Update TypeScript types and JSDoc comments - Update example files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Increase microphone bitrate from 128kbps to 256kbps - Change microphone audio from mono to stereo - Add retry loop (up to 10ms) when AVAssetWriter isn't ready - Reorder checks to silently discard audio before video starts - Remove noisy log spam for dropped samples Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add counters for dropped audio samples and video frames - Print summary at end of recording instead of logging each drop - Helps diagnose audio quality issues without console spam Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Audio from external devices (e.g., Elgato Wave Link) may have timestamps earlier than the first video frame, resulting in negative presentation times. These samples were being placed at time 0 in the output file, causing audio to play before the corresponding video. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add audioBitRate and audioCodec options to improve audio recording quality: - audioBitRate: configurable bitrate (default increased to 320kbps from 256kbps) - audioCodec: support for 'aac' (default), 'alac' (lossless), and 'pcm' (uncompressed) Apple Lossless (alac) provides highest quality for voice recordings without compression artifacts. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…king extra requests to find that in the tail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cropAreaparameter not being properly applied to the screen capturecropArea.widthandcropArea.heightwere used (for output dimensions), whilecropArea.xandcropArea.ywere ignoredChanges
Added proper ScreenCaptureKit configuration in
ScreenCaptureKitCli.swift:config.sourceRect = cropRectto specify which region of the screen to captureconfig.widthandconfig.heightbased on the crop area dimensions (scaled by display factor)Test plan
{x: 200, y: 200, width: 800, height: 600})🤖 Generated with Claude Code