Fix millisecond conversions for Request#166
Open
michaelsproul wants to merge 1 commit intofcsonline:masterfrom
Open
Fix millisecond conversions for Request#166michaelsproul wants to merge 1 commit intofcsonline:masterfrom
michaelsproul wants to merge 1 commit intofcsonline:masterfrom
Conversation
|
I ran into the same bug and this PR fixed it for me. Thanks :) Hope it gets merged by the maintainer soon. |
|
I ran into failing tests because of this bug as well. Thanks for the fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
RequestandReportto use a field calledduration_msto avoid the extra multiplication by 1000 described in #165.I chose to rename the field for clarity and to ensure that I'd accounted for all the places where it is used.
Closes #165