Skip to content

Conversation

@fderuiter
Copy link
Owner

πŸ—οΈ Architect: Refactor Endpoint Logic

πŸ—οΈ Design Change:

  • Moved from a monolithic _list_impl (handling both sync/async via inspect) to explicit _list_sync and _list_async methods in ListGetEndpointMixin.
  • Similarly split _get_impl into _get_sync and _get_async.
  • Introduced _process_filters hook to allow subclasses to extract parameters without overriding execution logic.

♻️ DRY Gains:

  • Centralized execution preparation in _prepare_execution.
  • Removed duplicate "is async" checks in JobsEndpoint and RecordsEndpoint.

πŸ›‘οΈ Solidity:

  • Decoupled Model parsing from HTTP fetching more clearly.
  • Enforced explicit types (List[T] vs Any).
  • BaseEndpoint._auto_filter now returns a copy, preventing side effects.

⚠️ Breaking Changes:

  • Internal methods _list_impl and _get_impl are removed. Subclasses relying on overriding these (like UsersEndpoint, RecordsEndpoint) have been updated to use _process_filters.
  • Unit tests mocking _list_impl were updated to mock _list_sync or _list_async.

PR created automatically by Jules for task 1845034591522279126 started by @fderuiter

Co-authored-by: fderuiter <127706008+fderuiter@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants