This repository was archived by the owner on May 14, 2024. It is now read-only.
Merged
Conversation
Add mouse "click and drag" to select text
fdionisi
force-pushed
the
add/implement-mouse-selections
branch
from
8783923 to
234fa4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pranaygp I had a look at the PR and found the potential issue:
animationFrameLoopwas being called recursively.I moved it to
TextEditor.handleMouseMovewhere I exit from it early whenthis.state.mouseDownisfalse, avoid callingwindow.requestAnimationFrame.It has been a long time, but if you have a chance to ensure my changes are not breaking something else that I'm not seeing it would be amazing.
Original PR: atom#107