Fixed inconsistencies in FDP SHACL#33
Open
dennisvang wants to merge 16 commits intodevelopmentfrom
Open
Conversation
dennisvang
changed the title
dennisvang
force-pushed
the
fix/shacl-inconsistencies
branch
from
b14d8cf to
c8e4a58
Compare
Contributor
Author
|
Question for future version: should we also specify that the DCAT parent classes need to be made explicit, as they are in the reference implementation? As it is now, inference is required in order to know that an |
dennisvang
changed the title
Contributor
Author
|
Replacing |
because it is not in the table
because this is in the table
that's what it should be, based on table and datatype
based on table
to match the table
for consistency and clarity although the textual definition in SHACL, section 4.1.2, says datatype validation fails if the value node is not a literal, it is better to be explicit
this property was not mentioned in the table yet todo: decide if cardinality should be 0..* or 1..* todo: improve description in table
….* to 0..* and adapt tables accordingly
now the order matches that of the generated statement: <membership-resource> <has-member-relation> <contains> this is also consistent with the order in the shacl file
- consistent use of prefixes - dont mix purl with fairdatapoint.org - rearrange to match order of shacl (for convenience) - remove dct:description (optional) - remove dct:hasVersion (not in shacl) - add fdp-o:conformsToFdpSpec (required) - add dcat:endPointURL (required) todo: - http://rdflicense.appspot.com does not resolve - https://www.purl.org/fairtools/fdp/schema/0.1/ does not resolve
following Luiz's example
dennisvang
force-pushed
the
fix/shacl-inconsistencies
branch
from
2c3f135 to
025de71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed inconsistencies between FDP SHACL file and corresponding tables.
See commit messages below for details.
fixes #30
TODO:
http://fairdatapoint.orgby some persistent url, and let that persistent url point to the github directory containing the raw ttl files?<#FAIRDataPointShape>and so on?