Conversation
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the solution layout, centralizes package version management, and enforces reproducible builds in CI.
- Centralize package versions by introducing
Directory.Packages.propsand removing inline version attributes. - Enable locked dependency restoration via
Directory.Build.propsand propagateContinuousIntegrationBuildin the GitHub Actions workflow. - Move project files under
src/andtests/, addglobal.jsonfor SDK pinning, and include centralized files in the solution.
Reviewed Changes
Copilot reviewed 9 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Light.TemporaryStreams.Tests/packages.lock.json | Add lockfile to pin test dependencies |
| tests/Light.TemporaryStreams.Tests/Light.TemporaryStreams.Tests.csproj | Remove inline versions, update project reference path to src/ |
| src/Light.TemporaryStreams/packages.lock.json | Add lockfile to pin library dependencies |
| src/Light.TemporaryStreams/Light.TemporaryStreams.csproj | Remove inline version to use centralized package versions |
| global.json | Pin .NET SDK to 8.0.411 with roll-forward disabled |
| Light.TemporaryStreams.sln | Update project paths to src/ and tests/, add solution folders |
| Directory.Packages.props | New central package version configuration |
| Directory.Build.props | Enable lockfile restore and locked mode under CI |
| .github/workflows/build-and-test.yml | Add /p:ContinuousIntegrationBuild=true, remove hardcoded SDK step |
Comments suppressed due to low confidence (2)
.github/workflows/build-and-test.yml:16
- The
setup-dotnetstep no longer specifies which SDK version to install. Add awith: dotnet-version: 8.0.x(or the new input syntax) so the action picks the correct SDK instead of failing or using an unexpected default.
uses: actions/setup-dotnet@v4
.github/workflows/build-and-test.yml:29
- Removing
--no-restorefrom the test command will trigger a restore again, slowing CI. If the intent was to skip redundant restores, re-add--no-restorehere.
run: dotnet test ./Light.TemporaryStreams.sln --configuration Release --no-build --verbosity normal
Owner
Author
|
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the
.NETproject, including enhanced build configuration, dependency management, and project structure organization. Key changes include enabling centralized package version management, adding support for locked dependency restoration, and restructuring the solution to better align with modern conventions.Build and Configuration Improvements:
.github/workflows/build-and-test.ymlto include the/p:ContinuousIntegrationBuild=trueparameter fordotnet restoreanddotnet buildcommands, enabling deterministic builds in CI environments.Directory.Build.propsto enable locked dependency restoration whenContinuousIntegrationBuildis true, ensuring reproducible builds.Dependency Management:
Directory.Packages.propsto centralize package version management, specifying versions for key dependencies such asFluentAssertions,Light.GuardClauses, andxunit.packages.lock.jsonto thesrc/Light.TemporaryStreamsdirectory to lock dependency versions, ensuring consistent resolution across environments.Project Structure Enhancements:
Light.TemporaryStreams.slnto reorganize project paths, moving source files tosrc/and test files totests/, improving clarity and maintainability. [1] [2]Directory.Packages.propsto the solution items inLight.TemporaryStreams.slnfor better visibility of centralized package management.