feat: Add per-service scaling & gRPC support by jatin5251 · Pull Request #5934 · feast-dev/feast

jatin5251 · 2026-02-02T08:03:16Z

What this PR does / why we need it:

Adds per-service deployments for Feast operator services so each service can scale independently (replicas per service).
Introduces an Online gRPC service alongside HTTP, with its own service + deployment and configurable gRPC settings (port, max_workers, registry_ttl, volume mounts).
Adds feature_server config passthrough in the FeatureStore CRD to enable MCP support in the feature server config.
Updates readiness checks and related CronJob selection to work with per-service deployments.
Regenerates CRDs / deepcopy and updates controller/service tests.
Adds a sample FeatureStore YAML showing gRPC + MCP configuration.

Which issue(s) this PR fixes:

Fixes # (or paste the issue URL)
(If required i can create Github issue)

Misc

Docs not updated in this PR (if you want, I can add a short doc update).

devin-ai-integration

Devin Review found 1 potential issue.

View issue and 5 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/util.go

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 11 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/services.go

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 22 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/services.go

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 25 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/services.go

devin-ai-integration

Devin Review found 2 new potential issues.

View issues and 25 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/services.go

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 25 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/services.go

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 32 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/util.go

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

devin-ai-integration

Devin Review found 2 new potential issues.

View issues and 47 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/util.go

infra/feast-operator/internal/controller/services/services.go

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 48 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/services.go

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 53 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/util.go

ntkathole · 2026-02-03T06:04:30Z

@Srihari1192 Can we please create an image and test these operator changes ?

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 56 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/services.go

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

…:jatin5251/feast into feat-feast-operator-mcp-grpc-per-service

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 56 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/services.go

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 56 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/services.go

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 58 additional flags in Devin Review.

infra/feast-operator/internal/controller/services/services.go

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

ntkathole · 2026-02-05T06:29:06Z

infra/feast-operator/internal/controller/services/services.go

+			cmd = append(cmd, "--registry_ttl_sec", strconv.Itoa(int(*grpcCfg.RegistryTTLSeconds)))
+		}
+	}
+	if tls := feast.getTlsConfigs(OnlineGrpcFeastType); tls.IsTLS() {


feast listen doesn't support --key/--cert options

ntkathole · 2026-02-05T06:30:51Z

infra/feast-operator/internal/controller/services/tls.go

 			},
 		}
 	}
+	if feast.onlineGrpcOpenshiftTls() {


gRPC server has NO TLS support at all and here we are trying to auto-enable broken TLS

ntkathole · 2026-02-05T06:43:47Z

infra/feast-operator/internal/controller/services/services.go

 }

-func (feast *FeastServices) setContainers(podSpec *corev1.PodSpec) error {
+func (feast *FeastServices) setContainers(podSpec *corev1.PodSpec, feastType FeastServiceType) error {


I see this is breaking change and there is no clear migration path from old deployment to new multiple deployments, single container each.

It keeps the old feast-my-store deployment. After upgrade:

Old feast-my-store (4 containers) keeps running

New feast-my-store-* (4-5 deployments) are created

Both run simultaneously = conflicts, duplicate services, data corruption risks

ntkathole · 2026-02-05T06:48:33Z

@jatin5251 If possible can we divide the PR into 2 phases, mainly because this contains core architecture changes.

Change from single multi-container deployment to multiple single-container deployments. (I think this needs community discussion/RFC with pros and cons)
Add gRPC online store service and MCP configuration.

Thoughts?

ntkathole · 2026-02-05T06:58:40Z

infra/feast-operator/internal/controller/services/services.go

 func (feast *FeastServices) mountPvcConfig(podSpec *corev1.PodSpec, pvcConfig *feastdevv1.PvcConfig, feastType FeastServiceType) {
 	if podSpec != nil && pvcConfig != nil {
-		volName := feast.initPVC(feastType).Name
+		volName := feast.initPVC(feast.pvcFeastType(feastType)).Name


With separate PVCs, I think it will break file-based persistence. Each pod only has access to its own storage. While materialization with file-based (parquet files), Online pod can't access offline PVC.

That requires a RWX PVC dynamic provisioner as a pre-requisite.

Multiple replicas / HA can be considered an advanced use case so I think that's a reasonable requirement.

Otherwise, not supporting non-distributed persistant storage should be documented.

astefanutti · 2026-02-17T14:26:04Z

infra/feast-operator/api/v1/featurestore_types.go

+type GrpcServerConfigs struct {
+	ContainerConfigs `json:",inline"`
+	// Replicas sets the number of replicas for the gRPC service deployment.
+	Replicas *int32 `json:"replicas,omitempty"`


Compatibility with autoscalers like HPA or KEDA must be managed carefully.

With that PR, this new field will conflict with autoscaling updates to the deployment scale sub-resources, as described in kubernetes/kubernetes#25238.

It may be possible to work-around it using server-side apply, though I wonder whether we should make it more explicit in the API and support different scaling policies, like HPA or KEDA.

astefanutti · 2026-02-17T14:34:28Z

@jatin5251 If possible can we divide the PR into 2 phases, mainly because this contains core architecture changes.

Change from single multi-container deployment to multiple single-container deployments. (I think this needs community discussion/RFC with pros and cons)

Add gRPC online store service and MCP configuration.

@jatin5251 I second @ntkathole it'd be helpful if you could break this PR along "atomic" functionalities.

jatin5251 requested a review from a team as a code owner February 2, 2026 08:03

jatin5251 changed the title ~~feat: add per-service scaling and grpc support~~ feat: Add per-service scaling & gRPC support Feb 2, 2026

devin-ai-integration bot reviewed Feb 2, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/util.go Outdated Show resolved Hide resolved

devin-ai-integration bot reviewed Feb 2, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

jatin5251 force-pushed the feat-feast-operator-mcp-grpc-per-service branch 3 times, most recently from e340591 to f7f7845 Compare February 2, 2026 15:38

devin-ai-integration bot reviewed Feb 2, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

jatin5251 force-pushed the feat-feast-operator-mcp-grpc-per-service branch from f7f7845 to 206c701 Compare February 2, 2026 15:42

devin-ai-integration bot reviewed Feb 2, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

jatin5251 force-pushed the feat-feast-operator-mcp-grpc-per-service branch from 206c701 to 38da893 Compare February 2, 2026 16:11

devin-ai-integration bot reviewed Feb 2, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

jatin5251 force-pushed the feat-feast-operator-mcp-grpc-per-service branch from 38da893 to c87e4be Compare February 2, 2026 17:03

devin-ai-integration bot reviewed Feb 2, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

jatin5251 force-pushed the feat-feast-operator-mcp-grpc-per-service branch from c87e4be to 9ff2621 Compare February 2, 2026 17:20

jatin5251 closed this Feb 2, 2026

jatin5251 reopened this Feb 2, 2026

devin-ai-integration bot reviewed Feb 2, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/util.go Show resolved Hide resolved

jatin5251 added 12 commits February 3, 2026 00:52

feat: add per-service scaling and grpc support

664fdca

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

fix: avoid default http when grpc only

fe4a6f1

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

test: update operator tests for per-service deployments

246fa44

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

refactor: reduce complexity in defaults and deploy

5646545

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

feat: Add per-service scaling and gRPC support

f396a6d

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

test: Fix reconcile error expectations

ee50edf

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

chore: Update install.yaml

8914508

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

chore: Update generated manifests and docs

9d81a14

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

chore: Addressed devin ai comments

836ca09

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

chore: retrigger CI

c288dce

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

chore: fixed test cases

06330e2

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

chore: fixed test cases

99b5ca7

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

jatin5251 force-pushed the feat-feast-operator-mcp-grpc-per-service branch from 5ff72f8 to 99b5ca7 Compare February 2, 2026 23:52

chore: fixed test cases

81350f6

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

devin-ai-integration bot reviewed Feb 3, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/util.go Show resolved Hide resolved

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

jatin5251 added 4 commits February 3, 2026 01:06

chore: fixed format issue

004552f

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

chore: fixed devin ai comments

918aab0

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

chore: remove unused variables

cc6b34b

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

chore: fixed test cases

44cc015

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

devin-ai-integration bot reviewed Feb 3, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

chore: fixed test cases

6cdc2fa

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

devin-ai-integration bot reviewed Feb 3, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/util.go Show resolved Hide resolved

Merge branch 'master' into feat-feast-operator-mcp-grpc-per-service

0f8a959

devin-ai-integration bot reviewed Feb 3, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

jatin5251 added 2 commits February 3, 2026 13:30

chore: addressed devin ai comments

d90e9f6

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

Merge branch 'feat-feast-operator-mcp-grpc-per-service' of github.com…

9572b69

…:jatin5251/feast into feat-feast-operator-mcp-grpc-per-service

devin-ai-integration bot reviewed Feb 3, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

chore: fixed test cases

b2d90fe

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

devin-ai-integration bot reviewed Feb 3, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

jatin5251 added 2 commits February 3, 2026 14:24

chore: fixed test cases

5488be8

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

chore: fixed test cases

af3dbae

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

devin-ai-integration bot reviewed Feb 3, 2026

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

jatin5251 added 2 commits February 3, 2026 14:51

chore: fixed test cases

4ce3f26

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

chore: fixed test cases

02bede9

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>

ntkathole requested changes Feb 5, 2026

View reviewed changes

ntkathole reviewed Feb 5, 2026

View reviewed changes

astefanutti reviewed Feb 17, 2026

View reviewed changes

Conversation

jatin5251 commented Feb 2, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ntkathole commented Feb 3, 2026

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ntkathole Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

ntkathole Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

ntkathole Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

ntkathole commented Feb 5, 2026

Uh oh!

ntkathole Feb 5, 2026

Choose a reason for hiding this comment

jatin5251 commented Feb 2, 2026 •

edited by devin-ai-integration bot

Loading