Skip to content

test: fix flaky /help assertion blocking publish#174

Merged
federiconeri merged 1 commit intomainfrom
fix/publish-help-test-flake
Apr 8, 2026
Merged

test: fix flaky /help assertion blocking publish#174
federiconeri merged 1 commit intomainfrom
fix/publish-help-test-flake

Conversation

@federiconeri
Copy link
Copy Markdown
Owner

Problem

Publish run 24127812074 failed during prepublish tests in job 70396723355.

Failing test:

  • src/tui/screens/MainShell.test.tsx > /help renders help text

The assertion depended on fixed sleeps and occasionally read the frame before the help message rendered.

Fix

  • add waitForFrameContains helper in MainShell test
  • submit /help explicitly in that test
  • wait until 'Available commands' appears (bounded timeout) instead of fixed-delay assertion
  • apply same deterministic wait to /h alias test

Verification

  • npm test -- src/tui/screens/MainShell.test.tsx (passed twice)

@federiconeri federiconeri merged commit edf1387 into main Apr 8, 2026
5 checks passed
@federiconeri federiconeri deleted the fix/publish-help-test-flake branch April 8, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant