-
-
Notifications
You must be signed in to change notification settings - Fork 119
Enforce example registration in test-examples
#941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dktsudgg
wants to merge
3
commits into
fedify-dev:main
Choose a base branch
from
dktsudgg:886-test-unregistered-example-detection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+99
−19
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "tasks": { | ||
| "test": "deno test --allow-all .", | ||
| "start": "deno run --allow-all mod.ts" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /** | ||
| * Registry-consistency tests for the example test runner. | ||
| * | ||
| * Every example directory under examples/ must be registered in exactly one | ||
| * of the registries in mod.ts (SERVER_EXAMPLES, SCRIPT_EXAMPLES, | ||
| * MULTI_HANDLE_EXAMPLES, or SKIPPED_EXAMPLES). These tests fail when a new | ||
| * example is added without being registered, so it cannot silently miss | ||
| * automated checks. | ||
| * | ||
| * Usage (from repository root): | ||
| * deno test --allow-all examples/test-examples | ||
| */ | ||
| import { fromFileUrl } from "@std/path"; | ||
| import assert from "node:assert/strict"; | ||
| import test from "node:test"; | ||
|
|
||
| import { getRegisteredExampleNames, scanUnregisteredExamples } from "./mod.ts"; | ||
|
|
||
| const EXAMPLES_DIR = fromFileUrl(new URL("../", import.meta.url)); | ||
|
|
||
| test("Every example in the examples/ directory is registered in test-examples", async () => { | ||
| const unregistered = await scanUnregisteredExamples(); | ||
| assert.deepEqual( | ||
| unregistered, | ||
| [], | ||
| `Unregistered example directories found: ${unregistered.join(", ")}`, | ||
| ); | ||
| }); | ||
|
|
||
| test("Every registered example has a matching examples/ directory", async () => { | ||
| const directories = new Set<string>(); | ||
| for await (const entry of Deno.readDir(EXAMPLES_DIR)) { | ||
| if (entry.isDirectory) directories.add(entry.name); | ||
| } | ||
| const unmatchedExamples = [...getRegisteredExampleNames()] | ||
| .filter((name) => !directories.has(name)) | ||
| .sort(); | ||
|
|
||
| assert.deepEqual( | ||
| unmatchedExamples, | ||
| [], | ||
| `Registered examples without a matching directory found: ${ | ||
| unmatchedExamples.join(", ") | ||
| }`, | ||
| ); | ||
| }); | ||
|
2chanhaeng marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the import to use
getRegisteredExampleDirsinstead ofgetRegisteredExampleNamesto support checking directory names rather than logical example names.