Simplified greenboot health-check by say-paul · Pull Request #100 · fedora-iot/greenboot

say-paul · 2023-03-29T13:52:34Z

This will implement the the existing greenboot health check functionality:
Below are the functionality that will be implemented as part of this PR:

greenboot params set up- health-check, rollback
Healthcheck process - required.d,wanted.d,red.d,green.d
Working with grub params - boot_counter,boot_success
MOTD
jouranld log
unit files

github-advanced-security · 2023-03-29T13:53:24Z

You have successfully added a new devskim configuration .github/workflows/analysis.yml:analysis_devskim. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

say-paul · 2023-03-29T14:10:48Z

I getting:
./greenboot health-check Config { max_reboot: 10, watchdog_check_enabled: false, watchdog_grace_period: 24 } INFO greenboot > running required check /usr/lib/greenboot/check/required.d/00_required_scripts_start.sh INFO greenboot > running wanted check /usr/lib/greenboot/check/wanted.d/00_wanted_scripts_start.sh INFO greenboot > greenbbot health-check passed. INFO greenboot > running green check /usr/lib/greenboot/green.d/00_required_scripts_start.sh thread 'main' panicked at 'unable to set grub variable: No such file or directory (os error 2)', src/main.rs:216:39

The grub variable boot_success is not set.

src/main.rs

say-paul · 2023-04-04T05:35:05Z

I getting: ./greenboot health-check Config { max_reboot: 10, watchdog_check_enabled: false, watchdog_grace_period: 24 } INFO greenboot > running required check /usr/lib/greenboot/check/required.d/00_required_scripts_start.sh INFO greenboot > running wanted check /usr/lib/greenboot/check/wanted.d/00_wanted_scripts_start.sh INFO greenboot > greenbbot health-check passed. INFO greenboot > running green check /usr/lib/greenboot/green.d/00_required_scripts_start.sh thread 'main' panicked at 'unable to set grub variable: No such file or directory (os error 2)', src/main.rs:216:39

The grub variable boot_success is not set.

its working now

dist/systemd/system/greenboot-trigger.service

src/main.rs

src/handler/mod.rs

miabbott · 2023-04-04T16:35:01Z

Would it be possible to break up the one monolithic commit into multiple commits?

It would ease the PR review process and make backing out changes easier.

src/handler/mod.rs

src/main.rs

4c5c297 0d9563b 1d54f0b 84bbd67 e37257b 2c0ac48 efa50df 7fff7fe Signed-off-by: Sayan Paul <paul.sayan@gmail.com>

greenboot-healtcheck: healthcheck which runs on every boot. greenboot-rollback: rollback(if healtcheck fails) which is tagged with systemd-update-done.service that runs, only after a system is updated. Signed-off-by: Sayan Paul <paul.sayan@gmail.com>

Makefile params: build,install,check,rpm spec - bump from v0.15 series which is bash version of greenboot to v0.16.0 Signed-off-by: Sayan Paul <paul.sayan@gmail.com>

CI runs formatting spellcheck and unit tests. packit build rpm for fedora and centos Signed-off-by: Sayan Paul <paul.sayan@gmail.com> Signed-off-by: Sayan Paul <paul.sayan@gmail.com>

devcontainer has all the necessary libaries installed to run test and build greenboot. Signedff-by: Sayan Paul <paul.sayan@gmail.com>

say-paul · 2024-04-16T06:44:45Z

I have major reservations about how get_boot_counter is handled, plus other minor things

I have modified this too.

src/handler/mod.rs

src/main.rs

src/handler/mod.rs

Signed-off-by: Sayan Paul <paul.sayan@gmail.com>

updated in commit: 00a2da7

saving 2 Bytes of ram!! Signed-off-by: Sayan Paul <paul.sayan@gmail.com>

moving the log related comments to issue #149

src/handler/mod.rs

src/main.rs

Signed-off-by: Sayan Paul <paul.sayan@gmail.com>

say-paul · 2025-03-20T06:15:35Z

moved to: https://github.com/fedora-iot/greenboot-rs

say-paul force-pushed the greenboot-rs-continued branch from 025530b to eacb3d5 Compare March 29, 2023 14:16

say-paul changed the title ~~Simplified greenboot~~ WIP:Simplified greenboot Mar 29, 2023

7flying reviewed Mar 29, 2023

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

7flying reviewed Mar 29, 2023

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

say-paul force-pushed the greenboot-rs-continued branch 3 times, most recently from 5dba90c to 665c669 Compare March 30, 2023 06:23

runcom reviewed Mar 30, 2023

View reviewed changes

src/main.rs Show resolved Hide resolved

say-paul changed the title ~~WIP:Simplified greenboot~~ Simplified greenboot Apr 3, 2023

say-paul force-pushed the greenboot-rs-continued branch 4 times, most recently from c836f58 to b4b06c6 Compare April 4, 2023 05:28

say-paul changed the title ~~Simplified greenboot~~ Simplified greenboot health-check Apr 4, 2023

runcom reviewed Apr 4, 2023

View reviewed changes

dist/systemd/system/greenboot-trigger.service Show resolved Hide resolved

sarmahaj reviewed Apr 4, 2023

View reviewed changes

miabbott reviewed Apr 4, 2023

View reviewed changes

src/handler/mod.rs Outdated Show resolved Hide resolved