fix: move fullscreen toggle from global keys to right panel#16
Merged
Conversation
The 'f' keybinding for toggling fullscreen is no longer intercepted globally by the shell. Consumer apps will handle the 'f' key in their right panel components and emit ToggleFullscreenMsg. The shell still processes that message to toggle the layout.
The 'f' key conflicted with the fullscreen toggle now handled by the right panel. Table page-down still works via pgdown and space.
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ToggleFullscreenfromGlobalKeyMapandCommonKeysfkey handler fromhandleGlobalKeysin shellffrom tablePageDownkeybinding (was conflicting)ToggleFullscreenMsgand its handler in shellUpdateare preserved — consumers emit it from their right panel componentsWhy
fwas a global key, which meant it was intercepted before reaching the focused panel. This caused conflicts with table page-down and consumer-specificfbindings (e.g. mrglab's pipeline filter). Fullscreen only applies to the right panel, so it belongs there.