refactor: remove exported color palettes, DefaultTheme, JiraTheme, and MainFrameStyle from style package#19
Merged
Conversation
…ainFrameStyle Remove all opinionated exports from the style package so it only exports the Theme struct. Consumers define their own themes. - Delete style/colors.go (ColorShades, Blue, Red, Green, Yellow, Violet, Orange, JiraBlue) - Remove DefaultTheme(), JiraTheme(), MainFrameStyle() from style/theme.go - Inline MainFrameStyle logic in shell.New() and DefaultLayoutConfig() - Add local defaultTheme() in hub/, shell/example/, and popover/examples/ - Update doc.go, README.md, and docs/ to not reference removed exports Closes #18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
Changes
style/colors.go— removedColorShadestype and all color palette variablesstyle/theme.goto only export theThemestructDefaultTheme(),JiraTheme(), andMainFrameStyle()defaultTheme()inhub/and all example directoriesMainFrameStylelogic where needed (shell/shell.go,layout.go)doc.go,README.md,docs/theming.md,docs/shell.mdBreaking Changes
Consumers that import
tuishell/stylefor palettes or theme constructors will need to:style.Theme{}instancetuishell/stylefor theThemestruct type