feat: add filter popover component#25
Merged
Merged
Conversation
Add FilterModel to the popover package — a reusable overlay component with checkbox sections and text input fields. Navigation uses tab/ shift+tab between fields, j/k within sections, space to toggle. - FilterSection/FilterOption/FilterInput types in messages.go - Open/Close/Apply message types for consumer integration - Dynamic help line based on active field type - 2-column grid layout for checkbox sections - PrimaryBright for focused items, Primary for unfocused - Example app in popover/examples/filter/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a reusable multi-select filter popover to the popover package. Supports checkbox sections (multi-select) and text input fields in a single overlay.
Changes
messages.go— AddedFilterSection,FilterOption,FilterInputtypes andOpenFilterPopoverMsg,CloseFilterPopoverMsg,ApplyFilterPopoverMsgmessagespopover/filter.go—FilterModelwith tab/shift+tab field navigation, j/k within sections, space toggle, dynamic help linepopover/examples/filter/— Example app demonstrating the componentDesign
PrimaryBrightfor focused items,Primaryfor unfocusedApplyFilterPopoverMsgcarries bothSelections map[string][]stringandInputs map[string]stringTesting
make buildandmake testpass