Skip to content

Today#62

Open
nebaz wants to merge 2 commits into
felixakiragreen:masterfrom
nebaz:today
Open

Today#62
nebaz wants to merge 2 commits into
felixakiragreen:masterfrom
nebaz:today

Conversation

@nebaz

@nebaz nebaz commented Aug 29, 2017

Copy link
Copy Markdown
  1. text "today" can be a react.element
  2. ability to hide the today button

@felixakiragreen

Copy link
Copy Markdown
Owner

Thank you for submitting a PR! A few questions before I merge it:

  1. Can you explain the use-case for wanting the text "today" to be a React.element?
  2. If it can be a React.element, does it still make sense for it to be buried in options.format.today or should it be its own prop?

@nebaz

nebaz commented Sep 1, 2017

Copy link
Copy Markdown
Author

for example, translate text "today" Instantly. To do this, I need to keep the text into react.element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants