Merged
Conversation
arredond
approved these changes
Jun 18, 2025
Collaborator
arredond
left a comment
arredond
left a comment
There was a problem hiding this comment.
Code changes make sense, thanks for keeping these updated! Added a comment about the deprecated caption argument to update_layer_group
|
|
||
| if name is not None: | ||
| json_payload["name"] = name | ||
| if caption is not None: |
Collaborator
There was a problem hiding this comment.
Since caption is deprecated (per the doc string), should we raise a warning when used?
Collaborator
Author
There was a problem hiding this comment.
Oh actually it's not deprecated, there's an error in our Open API spec! I'll get that fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the latest Felt API endpoints to the
felt_pythonlibrary