Add update_map with additional arguments#31
Merged
binaryseed merged 2 commits intomainfrom Jan 20, 2026
Merged
Conversation
binaryseed
changed the title
binaryseed
force-pushed
the
add-update_map-basemap
branch
from
908e60b to
20e7007
Compare
binaryseed
force-pushed
the
add-update_map-basemap
branch
from
20e7007 to
a31880d
Compare
arredond
reviewed
Jan 19, 2026
| The updated map | ||
| """ | ||
| json_args = {} | ||
| json_args: dict = {} |
Collaborator
There was a problem hiding this comment.
Is this type hint necessary? Seems redundant, I'd be surprised if a type checker complained about this one
Collaborator
Author
There was a problem hiding this comment.
% mypy .
felt_python/maps.py:160: error: Incompatible types in assignment (expression has type "dict[Any, Any]", target has type "str") [assignment]
felt_python/maps.py:162: error: Incompatible types in assignment (expression has type "dict[Any, Any]", target has type "str") [assignment]
Found 2 errors in 1 file (checked 22 source files)
arredond
approved these changes
Jan 19, 2026
binaryseed
force-pushed
the
add-update_map-basemap
branch
from
218a3e7 to
a31880d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
basemap,table_settings,viewer_permissionsarguments to theupdate_mapfunction. They are supported by the API but were missing