Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new) #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
node-linker=hoisted
min-release-age=259200
min-release-age-exclude=vite-plus,@voidzero-dev/*

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In pnpm v10, the correct configuration key for excluding packages from the release age policy is min-release-age-policy-exclude. The current key min-release-age-exclude is likely invalid and will be ignored by the package manager.

min-release-age-policy-exclude=vite-plus,@voidzero-dev/*

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@changesets/changelog-git": "^0.2.0",
"@changesets/cli": "^2.30.0",
"sherif": "^1.2.0",
"vite-plus": "latest"
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633"

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The PR description mentions updating vite and vitest aliases in overrides / resolutions, but these changes are missing from the diff. Please ensure these were not accidentally omitted from the commit.

Also, since vite-plus is updated to the same URL across multiple packages, consider using pnpm catalogs (v10+) in pnpm-workspace.yaml to manage this dependency centrally and avoid repetitive updates.

},
"packageManager": "pnpm@10.12.1",
"pnpm": {
Expand Down
2 changes: 1 addition & 1 deletion packages/bippy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
"react-refresh": "^0.16.0",
"terser": "^5.36.0",
"tsx": "^4.21.0",
"vite-plus": "latest"
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633"
},
"peerDependencies": {
"react": ">=17.0.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/vite-playground/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
"@vitejs/plugin-react": "^4.3.4",
"tailwindcss": "4.0.0-beta.8",
"typescript": "^5.7.3",
"vite-plus": "latest"
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633"
}
}
2 changes: 1 addition & 1 deletion packages/website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@
"tailwindcss": "^4",
"tw-animate-css": "^1.4.0",
"typescript": "^5",
"vite-plus": "latest"
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633"
}
}
1,294 changes: 666 additions & 628 deletions pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
packages:
- "packages/*"
- "packages/e2e/fixtures/*"
minimumReleaseAge: 4320
minimumReleaseAgeExclude:
- vite-plus
- "@voidzero-dev/*"
Comment on lines +4 to +7

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fields minimumReleaseAge and minimumReleaseAgeExclude are not standard for pnpm-workspace.yaml. Additionally, there is a unit inconsistency: .npmrc uses seconds (259200), while this file uses minutes (4320).

If these are intended for pnpm, they should be removed as they are already configured in .npmrc. If they are for a custom tool, consider standardizing the units and naming to match the package manager's configuration to avoid confusion and maintenance errors.

Loading