Skip to content

vp migrate beta test#6

Draft
fengmk2 wants to merge 2 commits into
masterfrom
vp-migrate-test
Draft

vp migrate beta test#6
fengmk2 wants to merge 2 commits into
masterfrom
vp-migrate-test

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 25, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project to the Vite+ unified toolchain, updating dependencies, lockfiles, and workspace configurations, as well as updating test files to import from vite-plus/test. Feedback on these changes includes correcting an invalid Oxc formatter configuration path in .vscode/settings.json and replacing temporary preview URLs for vite and vite-plus in pnpm-workspace.yaml with stable, published npm versions to ensure long-term installation stability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .vscode/settings.json
"[typescriptreact]": {
"editor.defaultFormatter": "oxc.oxc-vscode"
},
"oxc.fmt.configPath": "./vite.config.ts",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The setting "oxc.fmt.configPath" is configured to point to "./vite.config.ts". However, vite.config.ts is a Vite configuration file, not an Oxc formatter configuration file. Furthermore, there is no vite.config.ts file present in this repository. This invalid configuration may cause the Oxc extension to fail or behave unexpectedly. If you intended to configure the linter, you might want to use "oxc.lint.configPath" pointing to an oxlint.json file, or remove this setting if no custom formatter configuration is needed.

Comment thread pnpm-workspace.yaml
Comment on lines +5 to +7
vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@529396f85556c9ae7650dad6b52257b94a1fd0d2
vitest: 4.1.9
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@529396f85556c9ae7650dad6b52257b94a1fd0d2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The catalog uses temporary preview URLs from pkg.pr.new for vite and vite-plus. While this is useful for beta testing, these preview packages are not guaranteed to be permanently available and can lead to broken installations in the future. Please ensure these are replaced with stable, published npm versions before merging this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant