vp migrate beta test#4
Conversation
There was a problem hiding this comment.
Code Review
This pull request configures the workspace to use a pnpm catalog for vite and vite-plus dependencies and adds a registry bridge to .npmrc. The review feedback highlights that peerDependencyRules and minimumReleaseAgeExclude are incorrectly placed in pnpm-workspace.yaml and should be moved to package.json and .npmrc respectively. Additionally, a redundant package-level override for vite in package.json should be removed to avoid conflicts.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| peerDependencyRules: | ||
| allowAny: | ||
| - vite | ||
| allowedVersions: | ||
| vite: '*' | ||
| minimumReleaseAgeExclude: | ||
| - '@voidzero-dev/vite-plus-core@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442' | ||
| - '@voidzero-dev/vite-plus-darwin-arm64@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442' | ||
| - '@voidzero-dev/vite-plus-darwin-x64@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442' | ||
| - '@voidzero-dev/vite-plus-linux-arm64-gnu@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442' | ||
| - '@voidzero-dev/vite-plus-linux-arm64-musl@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442' | ||
| - '@voidzero-dev/vite-plus-linux-x64-gnu@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442' | ||
| - '@voidzero-dev/vite-plus-linux-x64-musl@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442' | ||
| - '@voidzero-dev/vite-plus-win32-arm64-msvc@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442' | ||
| - '@voidzero-dev/vite-plus-win32-x64-msvc@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442' | ||
| - vite-plus@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442 |
There was a problem hiding this comment.
Both peerDependencyRules and minimumReleaseAgeExclude are not valid configuration fields in pnpm-workspace.yaml and will be ignored by pnpm.
-
peerDependencyRules: This must be defined in the rootpackage.jsonunder thepnpm.peerDependencyRulesfield:"pnpm": { "peerDependencyRules": { "allowAny": ["vite"], "allowedVersions": { "vite": "*" } } }
-
minimumReleaseAgeExclude: This must be defined in.npmrcusing theminimum-release-age-excludesetting:minimum-release-age-exclude[]=@voidzero-dev/vite-plus-core@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442 minimum-release-age-exclude[]=@voidzero-dev/vite-plus-darwin-arm64@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442 minimum-release-age-exclude[]=@voidzero-dev/vite-plus-darwin-x64@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442 minimum-release-age-exclude[]=@voidzero-dev/vite-plus-linux-arm64-gnu@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442 minimum-release-age-exclude[]=@voidzero-dev/vite-plus-linux-arm64-musl@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442 minimum-release-age-exclude[]=@voidzero-dev/vite-plus-linux-x64-gnu@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442 minimum-release-age-exclude[]=@voidzero-dev/vite-plus-linux-x64-musl@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442 minimum-release-age-exclude[]=@voidzero-dev/vite-plus-win32-arm64-msvc@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442 minimum-release-age-exclude[]=@voidzero-dev/vite-plus-win32-x64-msvc@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442 minimum-release-age-exclude[]=vite-plus@0.0.0-commit.333e612a4d9d966e79724c336ba7bf422f79b442
You can apply the suggestion below to remove these invalid fields from pnpm-workspace.yaml.
| "vite": "catalog:", | ||
| "vite-plus": "catalog:" |
There was a problem hiding this comment.
Note that there is an existing override for vite in the overrides block of this package.json (line 29):
"vite": "npm:@voidzero-dev/vite-plus-core@latest"Since you have defined vite in the catalog and added a workspace-level override in pnpm-workspace.yaml pointing to the catalog, this package-level override in package.json is redundant and potentially conflicting. Consider removing it to keep the dependency resolution clean.
Pull Request Title
Linked GH Issues
Current Behavior
New Behavior