Skip to content

chore(deps): bump vite-plus to v0.2.0#15

Draft
fengmk2 wants to merge 2 commits into
masterfrom
update-vite-plus-prerelease-test-0.2.0
Draft

chore(deps): bump vite-plus to v0.2.0#15
fengmk2 wants to merge 2 commits into
masterfrom
update-vite-plus-prerelease-test-0.2.0

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related packages to the pkg.pr.new prerelease build for v0.2.0.

Updated where applicable:

  • vite-plus -> pkg.pr.new build
  • vite (alias/override -> @voidzero-dev/vite-plus-core)
  • vitest pinned to bundled 4.1.9 (the @voidzero-dev/vite-plus-test wrapper was removed upstream; vitest is now plain upstream)
  • minimumReleaseAge enabled with vite-plus packages excluded (pnpm/bun/npm as applicable)
  • moved the pnpm.overrides field from package.json into pnpm-workspace.yaml (the pnpm field is no longer read by pnpm)

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this Jun 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vite, vite-plus, and vitest dependencies to newer versions, removes the pnpm overrides block from package.json, and introduces a new pnpm-workspace.yaml file. The review feedback highlights three critical issues: first, the Node.js engine requirement in package.json must be updated to ^22.18.0 || >=24.11.0 to prevent installation failures with the updated packages; second, the pnpm-workspace.yaml file is unnecessary for this single-package repository and should be deleted; and third, the pnpm overrides and settings defined in the workspace file must be relocated to package.json and .npmrc respectively, as they are currently being ignored.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread package.json
"vitepress": "^1.6.3",
"vitepress-plugin-llms": "^1.11.0",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.24",
"vitest": "4.1.9",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The newly bumped vite-plus and @voidzero-dev/vite-plus-core packages (v0.2.0) require Node.js ^22.18.0 || >=24.11.0 as specified in their package engines (see pnpm-lock.yaml). However, the project's engines.node in package.json is still set to ^20.19.0 || >=22.12.0.

To prevent installation failures for users on Node 20, please update the engines.node field in package.json to match the new minimum requirement of ^22.18.0 || >=24.11.0 (or >=22.18.0).

Comment thread package.json
Comment on lines 101 to 102
"type": "module",
"pnpm": {
"overrides": {
"form-data@<2.5.4": ">=2.5.4",
"@rolldown/pluginutils": "1.0.0-rc.9",
"vite": "npm:@voidzero-dev/vite-plus-core@^0.1.24",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.24"
}
},
"packageManager": "pnpm@10.32.1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Since overrides are not supported in pnpm-workspace.yaml and must be defined in the root package.json under the "pnpm" field, we should restore the "pnpm" block here with the updated overrides.

  "type": "module",
  "pnpm": {
    "overrides": {
      "form-data@<2.5.4": ">=2.5.4",
      "@rolldown/pluginutils": "1.0.0-rc.9",
      "vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1856",
      "vitest": "4.1.9"
    }
  },
  "packageManager": "pnpm@10.32.1"

Comment thread pnpm-workspace.yaml
Comment on lines +1 to +20
overrides:
'form-data@<2.5.4': '>=2.5.4'
'@rolldown/pluginutils': 1.0.0-rc.9
vite: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1856'
vitest: '4.1.9'

minimumReleaseAge: 60
minimumReleaseAgeExclude:
- '@voidzero-dev/*'
- vite-plus
- '@vitest/*'
- vite
- vitest
- '@oxc-project/*'
- '@oxlint/*'
- oxlint
- oxfmt
- oxlint-tsgolint

blockExoticSubdeps: false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Since Koel is a single-package repository and not a monorepo, pnpm-workspace.yaml is not needed and should be removed.

Additionally, the configurations defined here are placed in the wrong files and will be silently ignored by pnpm:

  1. overrides: Must be defined in the root package.json under "pnpm": { "overrides": { ... } }.
  2. pnpm settings (minimumReleaseAge, minimumReleaseAgeExclude, blockExoticSubdeps): Must be configured in .npmrc using kebab-case.

Please delete this file and move the settings to .npmrc as follows:

minimum-release-age = 60
minimum-release-age-exclude = @voidzero-dev/*, vite-plus, @vitest/*, vite, vitest, @oxc-project/*, @oxlint/*, oxlint, oxfmt, oxlint-tsgolint
block-exotic-subdeps = false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant