chore(deps): bump vite-plus to v0.2.0#15
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite, vite-plus, and vitest dependencies to newer versions, removes the pnpm overrides block from package.json, and introduces a new pnpm-workspace.yaml file. The review feedback highlights three critical issues: first, the Node.js engine requirement in package.json must be updated to ^22.18.0 || >=24.11.0 to prevent installation failures with the updated packages; second, the pnpm-workspace.yaml file is unnecessary for this single-package repository and should be deleted; and third, the pnpm overrides and settings defined in the workspace file must be relocated to package.json and .npmrc respectively, as they are currently being ignored.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "vitepress": "^1.6.3", | ||
| "vitepress-plugin-llms": "^1.11.0", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.24", | ||
| "vitest": "4.1.9", |
There was a problem hiding this comment.
The newly bumped vite-plus and @voidzero-dev/vite-plus-core packages (v0.2.0) require Node.js ^22.18.0 || >=24.11.0 as specified in their package engines (see pnpm-lock.yaml). However, the project's engines.node in package.json is still set to ^20.19.0 || >=22.12.0.
To prevent installation failures for users on Node 20, please update the engines.node field in package.json to match the new minimum requirement of ^22.18.0 || >=24.11.0 (or >=22.18.0).
| "type": "module", | ||
| "pnpm": { | ||
| "overrides": { | ||
| "form-data@<2.5.4": ">=2.5.4", | ||
| "@rolldown/pluginutils": "1.0.0-rc.9", | ||
| "vite": "npm:@voidzero-dev/vite-plus-core@^0.1.24", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.24" | ||
| } | ||
| }, | ||
| "packageManager": "pnpm@10.32.1" |
There was a problem hiding this comment.
Since overrides are not supported in pnpm-workspace.yaml and must be defined in the root package.json under the "pnpm" field, we should restore the "pnpm" block here with the updated overrides.
"type": "module",
"pnpm": {
"overrides": {
"form-data@<2.5.4": ">=2.5.4",
"@rolldown/pluginutils": "1.0.0-rc.9",
"vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1856",
"vitest": "4.1.9"
}
},
"packageManager": "pnpm@10.32.1"| overrides: | ||
| 'form-data@<2.5.4': '>=2.5.4' | ||
| '@rolldown/pluginutils': 1.0.0-rc.9 | ||
| vite: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1856' | ||
| vitest: '4.1.9' | ||
|
|
||
| minimumReleaseAge: 60 | ||
| minimumReleaseAgeExclude: | ||
| - '@voidzero-dev/*' | ||
| - vite-plus | ||
| - '@vitest/*' | ||
| - vite | ||
| - vitest | ||
| - '@oxc-project/*' | ||
| - '@oxlint/*' | ||
| - oxlint | ||
| - oxfmt | ||
| - oxlint-tsgolint | ||
|
|
||
| blockExoticSubdeps: false |
There was a problem hiding this comment.
Since Koel is a single-package repository and not a monorepo, pnpm-workspace.yaml is not needed and should be removed.
Additionally, the configurations defined here are placed in the wrong files and will be silently ignored by pnpm:
overrides: Must be defined in the rootpackage.jsonunder"pnpm": { "overrides": { ... } }.- pnpm settings (
minimumReleaseAge,minimumReleaseAgeExclude,blockExoticSubdeps): Must be configured in.npmrcusing kebab-case.
Please delete this file and move the settings to .npmrc as follows:
minimum-release-age = 60
minimum-release-age-exclude = @voidzero-dev/*, vite-plus, @vitest/*, vite, vitest, @oxc-project/*, @oxlint/*, oxlint, oxfmt, oxlint-tsgolint
block-exotic-subdeps = false
Summary
Bump
vite-plusand related packages to the pkg.pr.new prerelease build for v0.2.0.Updated where applicable:
vite-plus-> pkg.pr.new buildvite(alias/override ->@voidzero-dev/vite-plus-core)vitestpinned to bundled4.1.9(the@voidzero-dev/vite-plus-testwrapper was removed upstream; vitest is now plain upstream)minimumReleaseAgeenabled with vite-plus packages excluded (pnpm/bun/npm as applicable)pnpm.overridesfield frompackage.jsonintopnpm-workspace.yaml(thepnpmfield is no longer read by pnpm)Test plan