chore(deps): bump vite-plus to pkg-pr-new pr-1588#5
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the devDependencies in package.json to use specific pkg.pr.new URLs for vite and vite-plus. It also attempts to add Socket configurations and package overrides to pnpm-workspace.yaml. However, these configurations are placed in the wrong file: overrides should be defined in the root package.json under pnpm.overrides, and Socket-specific settings should be placed in a socket.yml file.
| blockExoticSubdeps: false | ||
| minimumReleaseAge: 60 | ||
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" | ||
| - "@oxc-project/*" | ||
| - "@oxlint/*" | ||
| - oxlint | ||
| - oxfmt | ||
| - oxlint-tsgolint | ||
| - vitest | ||
| - "@vitest/*" | ||
|
|
||
| overrides: | ||
| "@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e" | ||
| "@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@5577b0154f33d1480a3c96347e94fa5d2094de2e" |
There was a problem hiding this comment.
The fields blockExoticSubdeps, minimumReleaseAge, minimumReleaseAgeExclude, and overrides are not valid configuration options for pnpm-workspace.yaml and will be ignored by pnpm.\n\n1. overrides: In pnpm, dependency overrides must be defined in the root package.json under the "pnpm.overrides" (or "overrides") field.\n2. Socket configurations (blockExoticSubdeps, etc.): These are Socket-specific settings and should be defined in a socket.yml file at the root of the repository.\n\nPlease remove these from pnpm-workspace.yaml and place them in their respective correct configuration files.
…pkg-pr-new pr-1588 bump
Summary
Bump vite-plus to pkg-pr-new build for PR #1588 (replace @voidzero-dev/vite-plus-test with upstream vitest@4.1.5).
Test plan