Skip to content

chore(deps): bump vite-plus to pkg-pr-new pr-1588#5

Draft
fengmk2 wants to merge 2 commits into
developfrom
update-vite-plus-prerelease-test-pr-1588
Draft

chore(deps): bump vite-plus to pkg-pr-new pr-1588#5
fengmk2 wants to merge 2 commits into
developfrom
update-vite-plus-prerelease-test-pr-1588

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus to pkg-pr-new build for PR #1588 (replace @voidzero-dev/vite-plus-test with upstream vitest@4.1.5).

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the devDependencies in package.json to use specific pkg.pr.new URLs for vite and vite-plus. It also attempts to add Socket configurations and package overrides to pnpm-workspace.yaml. However, these configurations are placed in the wrong file: overrides should be defined in the root package.json under pnpm.overrides, and Socket-specific settings should be placed in a socket.yml file.

Comment thread pnpm-workspace.yaml
Comment on lines +8 to +23
blockExoticSubdeps: false
minimumReleaseAge: 60
minimumReleaseAgeExclude:
- vite-plus
- "@voidzero-dev/*"
- "@oxc-project/*"
- "@oxlint/*"
- oxlint
- oxfmt
- oxlint-tsgolint
- vitest
- "@vitest/*"

overrides:
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e"
"@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@5577b0154f33d1480a3c96347e94fa5d2094de2e"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The fields blockExoticSubdeps, minimumReleaseAge, minimumReleaseAgeExclude, and overrides are not valid configuration options for pnpm-workspace.yaml and will be ignored by pnpm.\n\n1. overrides: In pnpm, dependency overrides must be defined in the root package.json under the "pnpm.overrides" (or "overrides") field.\n2. Socket configurations (blockExoticSubdeps, etc.): These are Socket-specific settings and should be defined in a socket.yml file at the root of the repository.\n\nPlease remove these from pnpm-workspace.yaml and place them in their respective correct configuration files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant