chore: vp migrate beta test#26
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the build and test configuration from tsdown to vite-plus and introduces pnpm catalogs for dependency management. Feedback focuses on removing a redundant vite-plus dependency from package.json, pinning the playwright version to avoid wildcard matching, and using the catalog protocol for the vite-plus override in pnpm-workspace.yaml.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "vite-plugin-pwa": "1.3.0", | ||
| "vite-plus": "0.1.20", | ||
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@670c987e4097d4e5d53bb4c0521c8bf643a33cf5", | ||
| "vue": "3.5.38", |
There was a problem hiding this comment.
The package vite-plus is declared in dependencies with a hardcoded URL, but it is also declared in devDependencies using "catalog:" (line 154). Having the same package in both dependencies and devDependencies is redundant and can cause package resolution issues.
Since vite-plus is a build-time tool, it should be removed from dependencies and managed solely via devDependencies using the catalog.
| "vite-plugin-pwa": "1.3.0", | |
| "vite-plus": "0.1.20", | |
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@670c987e4097d4e5d53bb4c0521c8bf643a33cf5", | |
| "vue": "3.5.38", | |
| "vite-plugin-pwa": "1.3.0", | |
| "vue": "3.5.38", |
| "markdown-it-anchor": "9.2.0", | ||
| "msw": "catalog:msw", | ||
| "msw-storybook-addon": "catalog:storybook", | ||
| "playwright": "*", |
There was a problem hiding this comment.
playwright is added with a wildcard version "*", while @playwright/test is pinned to "1.60.0". To prevent potential compatibility issues and ensure consistent test runs, it is highly recommended to pin playwright to the same version as @playwright/test.
| "playwright": "*", | |
| "playwright": "1.60.0", |
| vue-router: 5.0.4 | ||
| vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@670c987e4097d4e5d53bb4c0521c8bf643a33cf5 |
There was a problem hiding this comment.
In pnpm-workspace.yaml, vite-plus is overridden with a hardcoded URL. Since vite-plus is already defined in the catalog on line 65, you can use 'catalog:' here to keep the configuration DRY and maintainable.
vue-router: 5.0.4
vite-plus: 'catalog:'
e18e dependency analysisNo dependency warnings found. |
@nuxt/vite-builder imports 'rolldown' directly when running on rolldown-vite. The vp migration dropped @voidzero-dev/vite-plus-test, which was the only transitive provider of the standalone rolldown package, breaking 'vp run build'. Pin rolldown 1.1.2 to match the version vite-plus 0.2.1 bundles.
1 participant
🔗 Linked issue
🧭 Context
📚 Description