chore(deps): bump vite-plus to 0.1.21-alpha.7#4
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus dependency to version 0.1.21-alpha.7 in the default template and the workspace catalog. It also introduces a minimumReleaseAgeExclude section in the pnpm-workspace.yaml file. Feedback indicates that the vite dependency in the build catalog might also need an update for consistency and suggests that the wildcard pattern used for @voidzero-dev may not be supported by Bun, potentially requiring explicit package names.
| rolldown: ^1.0.0 | ||
| vite: ^8.0.11 | ||
| vite-plus: ^0.1.20 | ||
| vite-plus: 0.1.21-alpha.7 |
There was a problem hiding this comment.
The pull request description mentions that vite (aliased to @voidzero-dev/vite-plus-core) was updated where applicable, including catalogs. However, the vite entry in the build catalog (line 22) remains at ^8.0.11. If vite is part of the 0.1.21-alpha.7 release cycle, it should likely be updated here to a corresponding alpha version to ensure consistency across the workspace.
| protobufjs: true | ||
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
The wildcard pattern "@voidzero-dev/*" may not be supported by all tools mentioned in the PR description. Specifically, Bun's minimumReleaseAgeExclude configuration expects a list of literal package names and does not natively support glob patterns. To ensure this works correctly for Bun, you should list the specific packages under the @voidzero-dev scope that need to be excluded.
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan