chore(deps): bump vite-plus to v0.2.0#3
Conversation
commit: |
|
No React Doctor issues found. 🎉 Reviewed by React Doctor for commit |
There was a problem hiding this comment.
Code Review
This pull request updates project dependencies, transitioning @voidzero-dev/vite-plus-core and vite-plus to temporary pkg.pr.new URLs, upgrading vitest to version 4.1.9, and adjusting pnpm workspace configurations such as reducing minimumReleaseAge and disabling blockExoticSubdeps. The review feedback correctly highlights that using temporary pkg.pr.new URLs in package.json and pnpm-workspace.yaml poses a risk of future build failures once those builds expire, recommending stable npm-published versions instead. Furthermore, the reviewer advises maintaining the global minimumReleaseAge at its secure default of 7200 seconds, as the fast-moving packages have already been safely added to the exclusion list.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1856", | ||
| "cross-env": "^10.1.0", | ||
| "ts-json-schema-generator": "^2.9.0", | ||
| "turbo": "^2.9.7", | ||
| "typescript": "^6.0.3", | ||
| "vite-plus": "^0.1.15" | ||
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1856" |
There was a problem hiding this comment.
Using temporary pkg.pr.new URLs for dependencies in package.json is highly discouraged for stable/main branches. These builds are temporary and can be deleted or expire, which will eventually break the installation and build process for anyone cloning this repository in the future.
If v0.2.0 is published on npm, please use the published npm version instead. If this is a temporary PR for testing, please ensure these are replaced with stable npm registry versions before merging.
| "@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1856", | |
| "cross-env": "^10.1.0", | |
| "ts-json-schema-generator": "^2.9.0", | |
| "turbo": "^2.9.7", | |
| "typescript": "^6.0.3", | |
| "vite-plus": "^0.1.15" | |
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1856" | |
| "@voidzero-dev/vite-plus-core": "^0.2.0", | |
| "cross-env": "^10.1.0", | |
| "ts-json-schema-generator": "^2.9.0", | |
| "turbo": "^2.9.7", | |
| "typescript": "^6.0.3", | |
| "vite-plus": "^0.2.0" |
| overrides: | ||
| vite: npm:@voidzero-dev/vite-plus-core@^0.1.15 | ||
| vitest: npm:@voidzero-dev/vite-plus-test@^0.1.15 | ||
| vite: "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1856" |
There was a problem hiding this comment.
Similar to the dependencies in package.json, this override should point to a stable npm-published version (e.g., npm:@voidzero-dev/vite-plus-core@^0.2.0) instead of a temporary pkg.pr.new URL to prevent future installation failures when the temporary build expires.
vite: "npm:@voidzero-dev/vite-plus-core@^0.2.0"| - "packages/*" | ||
|
|
||
| minimumReleaseAge: 7200 | ||
| minimumReleaseAge: 60 |
There was a problem hiding this comment.
Reducing the global minimumReleaseAge to 60 seconds significantly weakens the security benefits of this feature against dependency confusion and supply chain attacks.
Since you have already added all the fast-moving/prerelease packages (like @voidzero-dev/*, vite-plus, vitest, etc.) to the minimumReleaseAgeExclude list, you can safely keep the global minimumReleaseAge at its original secure value of 7200 seconds (2 hours).
minimumReleaseAge: 7200
Summary
Bump
vite-plusand related packages to the pkg.pr.new prerelease build for v0.2.0.Updated where applicable:
vite-plus-> pkg.pr.new buildvite(alias/override ->@voidzero-dev/vite-plus-core)vitestpinned to bundled4.1.9(the@voidzero-dev/vite-plus-testwrapper was removed upstream; vitest is now plain upstream)minimumReleaseAgeenabled with vite-plus packages excluded (pnpm/bun/npm as applicable)Test plan