Vp migrate test#12
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates workspace and project configurations, transitioning dependencies like vite, vite-plus, and vitest to use pnpm catalogs, and configuring VS Code settings to use the Oxc formatter. Feedback on these changes highlights a critical stability risk due to the use of ephemeral package sources (pkg.pr.new) for dependencies in pnpm-workspace.yaml. Additionally, it is recommended to reference the catalog for the vite-plus override to maintain consistency with other overrides.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@670c987e4097d4e5d53bb4c0521c8bf643a33cf5 | ||
| vitest: 4.1.9 | ||
| vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@670c987e4097d4e5d53bb4c0521c8bf643a33cf5 |
There was a problem hiding this comment.
Using dependencies from a temporary pull request package source (pkg.pr.new) introduces a significant risk for stability and security. These packages are likely ephemeral and could be removed at any time, which would break the project for anyone trying to install dependencies.
For long-term stability, all dependencies should be sourced from a stable, trusted registry like npmjs.org or a dedicated private registry. If this change is for testing purposes, it should not be merged into a main branch.
| vite: 'npm:@voidzero-dev/vite-plus-core@0.2.1' | ||
| vite: 'catalog:' | ||
| vitest: 'catalog:' | ||
| vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@670c987e4097d4e5d53bb4c0521c8bf643a33cf5 |
There was a problem hiding this comment.
For consistency with the other overrides (vite and vitest), this should also reference the catalog. This improves maintainability by keeping the dependency source definitions in one place (the catalog section).
vite-plus: 'catalog:'The pkg.pr.new tarball deps (vite-plus, vite-plus-core and platform binaries) had no integrity field, so CI's frozen install failed with ERR_PNPM_MISSING_TARBALL_INTEGRITY (pnpm >= 11.4). Regenerated the lockfile via a clean install so pnpm re-downloads and hashes the tarballs.
Readable.isReadable() returns boolean | null in newer Node types, which failed type-aware lint (TS2322) against the boolean return type.
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
=======================================
Coverage 94.24% 94.24%
=======================================
Files 10 10
Lines 747 747
Branches 235 235
=======================================
Hits 704 704
Misses 40 40
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
No description provided.