Skip to content

chore(deps): bump vite-plus to v0.1.24 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

chore(deps): bump vite-plus to v0.1.24 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bf3778
chore(deps): bump vite-plus to v0.1.24 (pkg-pr-new PR #1738)
fengmk2 Jun 1, 2026
dc33ef1
chore(deps): refresh lockfile after vite-plus v0.1.24 bump
fengmk2 Jun 1, 2026
469b108
fix(deps): add pkg.pr.new tarball integrity to lockfile
fengmk2 Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,5 @@
"node": "^20.19.0 || >=22.12.0",
"pnpm": ">=9.0.0"
},
"packageManager": "pnpm@9.15.9",
"pnpm": {
"overrides": {
"vite": "catalog:",
"vitest": "catalog:"
}
}
"packageManager": "pnpm@9.15.9"
}
Comment on lines +40 to 41

@gemini-code-assist gemini-code-assist Bot Jun 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Moving the pnpm.overrides configuration to pnpm-workspace.yaml is not supported by pnpm@9.15.9. pnpm only reads overrides from the root package.json (under the pnpm.overrides or overrides field). Leaving this in pnpm-workspace.yaml will cause pnpm to ignore these overrides, resulting in incorrect versions of vite and vitest being resolved for sub-dependencies.

Please restore the pnpm.overrides configuration in the root package.json.

Suggested change
"packageManager": "pnpm@9.15.9"
}
"packageManager": "pnpm@9.15.9",
"pnpm": {
"overrides": {
"vite": "catalog:",
"vitest": "catalog:"
}
}
}

4 changes: 2 additions & 2 deletions packages/varlet-cli/template/generators/base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@
"@vue/test-utils": "2.4.6",
"@vue/runtime-core": "3.5.21",
"@vitest/coverage-istanbul": "4.1.4",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.18",
"vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1738",
"clipboard": "^2.0.6",
"jsdom": "26.1.0",
"live-server": "^1.2.1",
"rattail": "^2.0.3",
"typescript": "5.6.3",
"vite-plus": "0.1.18",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1738",
Comment on lines +49 to +55

@gemini-code-assist gemini-code-assist Bot Jun 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Hardcoding temporary pkg.pr.new URLs in a template generator's package.json is highly discouraged. When users generate a new project using this template, their project will be locked to these temporary, potentially unstable PR build URLs instead of official npm registry releases.

Once the PR is merged and the official v0.1.24 release of vite-plus is published to npm, please update these dependencies to use the standard npm registry versions (e.g., npm:@voidzero-dev/vite-plus-test@0.1.24 and 0.1.24).

"vue": "3.5.21",
"vue-router": "4.5.1"
},
Expand Down
Loading
Loading